Refactoring Me2MeNativeMessagingHost to implement NativeMessageHost interface

Refactoring Me2MeNativeMessagingHost to implement NativeMessageHost interface

This change updates the Me2Me native messaging host to use the same interface
as the It2Me native messaging host.  This change reduces the differences
between the two hosts and will make it simpler to continue the refactoring in
my next change to allow Me2Me and It2Me native messaging hosts to share the
same process elevation logic and communication channel.

BUG=617185
Committed: https://crrev.com/d4e32e5c0e660268a8e262f6b58ed5412d62a304
Cr-Commit-Position: refs/heads/master@{#409046}

[joedow, 2016-07-16 01:38:10]

The CQ bit was checked by joedow@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-16 01:38:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-16 02:45:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-16 02:45:26]

Dry run: This issue passed the CQ dry run.

[joedow, 2016-07-27 03:14:19]

The CQ bit was checked by joedow@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 03:14:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 04:17:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 04:17:41]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[joedow, 2016-07-29 02:57:48]

The CQ bit was checked by joedow@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-29 02:58:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[joedow, 2016-07-29 03:33:23]

joedow@chromium.org changed reviewers:
+ sergeyu@chromium.org

[joedow, 2016-07-29 03:33:24]

PTAL!

[commit-bot: I haz the power, 2016-07-29 03:51:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-29 03:51:05]

Dry run: This issue passed the CQ dry run.

[Sergey Ulanov, 2016-08-01 18:45:19]

lgtm

https://codereview.chromium.org/2153313002/diff/60001/remoting/host/setup/me2...
File remoting/host/setup/me2me_native_messaging_host.cc (right):

https://codereview.chromium.org/2153313002/diff/60001/remoting/host/setup/me2...
remoting/host/setup/me2me_native_messaging_host.cc:255: OnError(std::string());
OnError("'hostId' not found")?

https://codereview.chromium.org/2153313002/diff/60001/remoting/host/setup/me2...
remoting/host/setup/me2me_native_messaging_host.cc:261: OnError(std::string());
same here

https://codereview.chromium.org/2153313002/diff/60001/remoting/host/setup/me2...
File remoting/host/setup/me2me_native_messaging_host.h (right):

https://codereview.chromium.org/2153313002/diff/60001/remoting/host/setup/me2...
remoting/host/setup/me2me_native_messaging_host.h:136: private:
nit: empty line above this one

[joedow, 2016-08-01 19:19:40]

The CQ bit was checked by joedow@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-01 19:20:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[joedow, 2016-08-01 19:21:34]

Thanks!

https://codereview.chromium.org/2153313002/diff/60001/remoting/host/setup/me2...
File remoting/host/setup/me2me_native_messaging_host.cc (right):

https://codereview.chromium.org/2153313002/diff/60001/remoting/host/setup/me2...
remoting/host/setup/me2me_native_messaging_host.cc:255: OnError(std::string());
On 2016/08/01 18:45:18, Sergey Ulanov wrote:
> OnError("'hostId' not found")?

Done.

https://codereview.chromium.org/2153313002/diff/60001/remoting/host/setup/me2...
remoting/host/setup/me2me_native_messaging_host.cc:261: OnError(std::string());
On 2016/08/01 18:45:19, Sergey Ulanov wrote:
> same here

Done.

https://codereview.chromium.org/2153313002/diff/60001/remoting/host/setup/me2...
File remoting/host/setup/me2me_native_messaging_host.h (right):

https://codereview.chromium.org/2153313002/diff/60001/remoting/host/setup/me2...
remoting/host/setup/me2me_native_messaging_host.h:136: private:
On 2016/08/01 18:45:19, Sergey Ulanov wrote:
> nit: empty line above this one

Done.

[commit-bot: I haz the power, 2016-08-01 20:26:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-01 20:26:24]

Dry run: This issue passed the CQ dry run.

[joedow, 2016-08-01 20:29:09]

The CQ bit was checked by joedow@chromium.org

[joedow, 2016-08-01 20:29:09]

The patchset sent to the CQ was uploaded after l-g-t-m from sergeyu@chromium.org
Link to the patchset: https://codereview.chromium.org/2153313002/#ps80001
(title: "Addressing CR feedback")

[commit-bot: I haz the power, 2016-08-01 20:29:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-01 20:34:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-01 20:34:36]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[joedow, 2016-08-01 20:36:01]

The CQ bit was checked by joedow@chromium.org

[commit-bot: I haz the power, 2016-08-01 20:36:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-01 20:40:22]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-08-01 20:47:36]

Description was changed from

==========
Refactoring Me2MeNativeMessagingHost to implement NativeMessageHost interface

This change updates the Me2Me native messaging host to use the same interface
as the It2Me native messaging host.  This change reduces the differences
between the two hosts and will make it simpler to continue the refactoring in
my next change to allow Me2Me and It2Me native messaging hosts to share the
same process elevation logic and communication channel.

BUG=617185
==========

to

==========
Refactoring Me2MeNativeMessagingHost to implement NativeMessageHost interface

This change updates the Me2Me native messaging host to use the same interface
as the It2Me native messaging host.  This change reduces the differences
between the two hosts and will make it simpler to continue the refactoring in
my next change to allow Me2Me and It2Me native messaging hosts to share the
same process elevation logic and communication channel.

BUG=617185

Committed: https://crrev.com/d4e32e5c0e660268a8e262f6b58ed5412d62a304
Cr-Commit-Position: refs/heads/master@{#409046}
==========

[commit-bot: I haz the power, 2016-08-01 20:47:37]

Patchset 5 (id:??) landed as
https://crrev.com/d4e32e5c0e660268a8e262f6b58ed5412d62a304
Cr-Commit-Position: refs/heads/master@{#409046}