Refactoring Native Messaging Host process launching code into its own file.

Refactoring Native Messaging Host process launching code into its own file.

This change will allow Me2Me and It2Me native messaging hosts to use the same
code to launch and commnicate with an elevated (admin/uiaccess) child process.

BUG=617185
Committed: https://crrev.com/e99d91e315defc0b0e01e9b533c3284a07035d66
Cr-Commit-Position: refs/heads/master@{#409043}

[joedow, 2016-07-15 21:39:59]

The CQ bit was checked by joedow@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-15 21:40:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-16 00:13:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-16 00:13:06]

Dry run: This issue passed the CQ dry run.

[joedow, 2016-07-27 00:09:38]

The CQ bit was checked by joedow@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 00:09:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 01:08:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 01:08:47]

Dry run: This issue passed the CQ dry run.

[joedow, 2016-07-28 03:04:33]

joedow@chromium.org changed reviewers:
+ sergeyu@chromium.org

[joedow, 2016-07-28 03:04:34]

PTAL!

Thanks,
Joe

[Sergey Ulanov, 2016-07-28 23:57:15]

lgtm

https://codereview.chromium.org/2152953002/diff/40001/remoting/host/win/launc...
File remoting/host/win/launch_native_messaging_host_process.cc (right):

https://codereview.chromium.org/2152953002/diff/40001/remoting/host/win/launc...
remoting/host/win/launch_native_messaging_host_process.cc:32: const uint32_t
kSecurityDescriptorCreationFailed = 1;
This special error code is not mentioned in the header, but maybe you don't need
it if you change return type to bool.

https://codereview.chromium.org/2152953002/diff/40001/remoting/host/win/launc...
remoting/host/win/launch_native_messaging_host_process.cc:140: for
(base::CommandLine::StringVector::const_iterator i = args.begin();
for (const auto& arg : args) ...

https://codereview.chromium.org/2152953002/diff/40001/remoting/host/win/launc...
File remoting/host/win/launch_native_messaging_host_process.h (right):

https://codereview.chromium.org/2152953002/diff/40001/remoting/host/win/launc...
remoting/host/win/launch_native_messaging_host_process.h:22: uint32_t
LaunchNativeMessagingHostProcess(
Return bool instead of uint32_t?
The actual error code is not used by the caller. If the error code is useful
then maybe use int, intead of int32_t?

[joedow, 2016-07-29 02:52:03]

The CQ bit was checked by joedow@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-29 02:52:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[joedow, 2016-07-29 03:32:56]

Thanks!

https://codereview.chromium.org/2152953002/diff/40001/remoting/host/win/launc...
File remoting/host/win/launch_native_messaging_host_process.cc (right):

https://codereview.chromium.org/2152953002/diff/40001/remoting/host/win/launc...
remoting/host/win/launch_native_messaging_host_process.cc:32: const uint32_t
kSecurityDescriptorCreationFailed = 1;
On 2016/07/28 23:57:15, Sergey Ulanov wrote:
> This special error code is not mentioned in the header, but maybe you don't
need
> it if you change return type to bool.

Done.

https://codereview.chromium.org/2152953002/diff/40001/remoting/host/win/launc...
remoting/host/win/launch_native_messaging_host_process.cc:140: for
(base::CommandLine::StringVector::const_iterator i = args.begin();
On 2016/07/28 23:57:15, Sergey Ulanov wrote:
> for (const auto& arg : args) ...

Good call.

https://codereview.chromium.org/2152953002/diff/40001/remoting/host/win/launc...
File remoting/host/win/launch_native_messaging_host_process.h (right):

https://codereview.chromium.org/2152953002/diff/40001/remoting/host/win/launc...
remoting/host/win/launch_native_messaging_host_process.h:22: uint32_t
LaunchNativeMessagingHostProcess(
On 2016/07/28 23:57:15, Sergey Ulanov wrote:
> Return bool instead of uint32_t?
> The actual error code is not used by the caller. If the error code is useful
> then maybe use int, intead of int32_t?

I need at least three states (success, failure, cancelled) so I will simlpify
the return value but use an enum instead of a bool.

[commit-bot: I haz the power, 2016-07-29 03:44:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-29 03:44:26]

Dry run: This issue passed the CQ dry run.

[joedow, 2016-08-01 19:20:25]

The CQ bit was checked by joedow@chromium.org

[joedow, 2016-08-01 19:20:25]

The patchset sent to the CQ was uploaded after l-g-t-m from sergeyu@chromium.org
Link to the patchset: https://codereview.chromium.org/2152953002/#ps60001
(title: "Addressing CR feedback.")

[commit-bot: I haz the power, 2016-08-01 19:20:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-01 20:28:39]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-01 20:33:23]

Description was changed from

==========
Refactoring Native Messaging Host process launching code into its own file.

This change will allow Me2Me and It2Me native messaging hosts to use the same
code to launch and commnicate with an elevated (admin/uiaccess) child process.

BUG=617185
==========

to

==========
Refactoring Native Messaging Host process launching code into its own file.

This change will allow Me2Me and It2Me native messaging hosts to use the same
code to launch and commnicate with an elevated (admin/uiaccess) child process.

BUG=617185

Committed: https://crrev.com/e99d91e315defc0b0e01e9b533c3284a07035d66
Cr-Commit-Position: refs/heads/master@{#409043}
==========

[commit-bot: I haz the power, 2016-08-01 20:33:24]

Patchset 4 (id:??) landed as
https://crrev.com/e99d91e315defc0b0e01e9b533c3284a07035d66
Cr-Commit-Position: refs/heads/master@{#409043}