Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 2153243003: [Extensions] Clean up unnecessary copy (Closed)

Created:
4 years, 5 months ago by Devlin
Modified:
4 years, 5 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, felt, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Clean up unnecessary copy BUG=None Committed: https://crrev.com/21876decbbfebe37f54708c3804c379e7894a3c8 Cr-Commit-Position: refs/heads/master@{#405903}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M chrome/browser/extensions/api/activity_log_private/activity_log_private_api.cc View 1 chunk +3 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Devlin
And a third (sorry!). Found this one in the course of https://codereview.chromium.org/2152373003/ and it bothered ...
4 years, 5 months ago (2016-07-15 22:13:05 UTC) #2
lazyboy
lgtm
4 years, 5 months ago (2016-07-15 22:29:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2153243003/1
4 years, 5 months ago (2016-07-15 23:43:05 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-15 23:49:29 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-15 23:49:35 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 23:51:05 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/21876decbbfebe37f54708c3804c379e7894a3c8
Cr-Commit-Position: refs/heads/master@{#405903}

Powered by Google App Engine
This is Rietveld 408576698