Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(839)

Unified Diff: chrome/browser/extensions/api/activity_log_private/activity_log_private_api.cc

Issue 2153243003: [Extensions] Clean up unnecessary copy (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/activity_log_private/activity_log_private_api.cc
diff --git a/chrome/browser/extensions/api/activity_log_private/activity_log_private_api.cc b/chrome/browser/extensions/api/activity_log_private/activity_log_private_api.cc
index ed8cd7b117c19926c7061a9a5e69c719612a48a7..e5a6ffa422730ad74159d56ead087e14138ffa67 100644
--- a/chrome/browser/extensions/api/activity_log_private/activity_log_private_api.cc
+++ b/chrome/browser/extensions/api/activity_log_private/activity_log_private_api.cc
@@ -209,12 +209,9 @@ ExtensionFunction::ResponseAction ActivityLogPrivateDeleteUrlsFunction::Run() {
// Put the arguments in the right format.
std::vector<GURL> gurls;
- std::vector<std::string> urls = *params->urls.get();
- for (std::vector<std::string>::iterator it = urls.begin();
- it != urls.end();
- ++it) {
- gurls.push_back(GURL(*it));
- }
+ const std::vector<std::string>& urls = *params->urls;
+ for (const std::string& url : urls)
+ gurls.push_back(GURL(url));
ActivityLog* activity_log = ActivityLog::GetInstance(browser_context());
DCHECK(activity_log);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698