Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2153223002: GN: Use icf=all instead of icf=safe (Closed)

Created:
4 years, 5 months ago by stevenjb
Modified:
4 years, 5 months ago
CC:
chromium-reviews, Lukasz Jagielski
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Use icf=all instead of icf=safe BUG=628441 Committed: https://crrev.com/b2eb9de87515796cf9b7c17fd31a34d92427eb8b Cr-Commit-Position: refs/heads/master@{#405909}

Patch Set 1 #

Total comments: 5

Patch Set 2 : cros only #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M build/config/compiler/BUILD.gn View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 22 (6 generated)
stevenjb
crbug.com/576197 is marked resoved. 'safe' vs. 'all' increases the chrome on chromeos binary size for ...
4 years, 5 months ago (2016-07-15 20:42:30 UTC) #2
Dirk Pranke
https://codereview.chromium.org/2153223002/diff/1/build/config/compiler/BUILD.gn File build/config/compiler/BUILD.gn (right): https://codereview.chromium.org/2153223002/diff/1/build/config/compiler/BUILD.gn#newcode362 build/config/compiler/BUILD.gn:362: } else { won't this still break linux/gcc x86? ...
4 years, 5 months ago (2016-07-15 21:08:42 UTC) #5
stevenjb
https://codereview.chromium.org/2153223002/diff/1/build/config/compiler/BUILD.gn File build/config/compiler/BUILD.gn (right): https://codereview.chromium.org/2153223002/diff/1/build/config/compiler/BUILD.gn#newcode362 build/config/compiler/BUILD.gn:362: } else { On 2016/07/15 21:08:42, Dirk Pranke wrote: ...
4 years, 5 months ago (2016-07-15 21:12:07 UTC) #6
stevenjb
4 years, 5 months ago (2016-07-15 21:12:08 UTC) #7
stevenjb
4 years, 5 months ago (2016-07-15 21:12:12 UTC) #8
llozano
https://codereview.chromium.org/2153223002/diff/1/build/config/compiler/BUILD.gn File build/config/compiler/BUILD.gn (right): https://codereview.chromium.org/2153223002/diff/1/build/config/compiler/BUILD.gn#newcode362 build/config/compiler/BUILD.gn:362: } else { On 2016/07/15 21:08:42, Dirk Pranke wrote: ...
4 years, 5 months ago (2016-07-15 21:12:27 UTC) #9
stevenjb
So, is this the change we want?
4 years, 5 months ago (2016-07-15 21:21:30 UTC) #10
Dirk Pranke
https://codereview.chromium.org/2153223002/diff/1/build/config/compiler/BUILD.gn File build/config/compiler/BUILD.gn (right): https://codereview.chromium.org/2153223002/diff/1/build/config/compiler/BUILD.gn#newcode362 build/config/compiler/BUILD.gn:362: } else { I agree that we should update ...
4 years, 5 months ago (2016-07-15 21:30:05 UTC) #11
stevenjb
https://codereview.chromium.org/2153223002/diff/1/build/config/compiler/BUILD.gn File build/config/compiler/BUILD.gn (right): https://codereview.chromium.org/2153223002/diff/1/build/config/compiler/BUILD.gn#newcode362 build/config/compiler/BUILD.gn:362: } else { On 2016/07/15 21:30:05, Dirk Pranke wrote: ...
4 years, 5 months ago (2016-07-15 21:36:49 UTC) #12
stevenjb
4 years, 5 months ago (2016-07-15 21:36:53 UTC) #13
Dirk Pranke
lgtm.
4 years, 5 months ago (2016-07-15 22:18:32 UTC) #14
llozano1
lgtm
4 years, 5 months ago (2016-07-15 22:24:28 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2153223002/20001
4 years, 5 months ago (2016-07-15 22:27:20 UTC) #18
chromium-reviews
I was looking at this in more detail and the icf bug is not fixed ...
4 years, 5 months ago (2016-07-15 22:45:19 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-16 00:17:41 UTC) #20
commit-bot: I haz the power
4 years, 5 months ago (2016-07-16 00:19:46 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b2eb9de87515796cf9b7c17fd31a34d92427eb8b
Cr-Commit-Position: refs/heads/master@{#405909}

Powered by Google App Engine
This is Rietveld 408576698