Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2973)

Unified Diff: build/config/compiler/BUILD.gn

Issue 2153223002: GN: Use icf=all instead of icf=safe (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: cros only Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index 30d801789d8a36aeab008f75aeedea2afacebe79..91f40810a826672c7062fc11c551e267711e51c6 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -357,12 +357,13 @@ config("compiler") {
if (is_posix && (use_gold || (use_lld && !is_nacl)) && !using_sanitizer &&
!(is_android && use_order_profiling)) {
# TODO(crbug.com/576197) - gcc on x86 platforms + gold + icf=all
- # doesn't currently work. Once it does, use icf=all everywhere.
+ # doesn't currently work on non-chromeos platforms.
# Additionally, on Android x86 --icf=safe seems to cause issues as well.
# Additionally, on cast Android x86, --icf=all causes issues.
if (is_android && current_cpu == "x86") {
ldflags += [ "-Wl,--icf=none" ]
- } else if (is_clang || (current_cpu != "x86" && current_cpu != "x64")) {
+ } else if (is_clang || is_chromeos ||
+ (current_cpu != "x86" && current_cpu != "x64")) {
ldflags += [ "-Wl,--icf=all" ]
} else if (!is_android) {
ldflags += [ "-Wl,--icf=safe" ]
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698