Add gesture type value from desktop prompt to permission report

chrome/browser/permissions/permission_uma_util.cc

Index: chrome/browser/permissions/permission_uma_util.cc
diff --git a/chrome/browser/permissions/permission_uma_util.cc b/chrome/browser/permissions/permission_uma_util.cc
index d25bc5befe38b005782c97b6a64d3cc1342fb95e..a37c0fd6acd0305ebee87f43389e449883e77a88 100644
--- a/chrome/browser/permissions/permission_uma_util.cc
+++ b/chrome/browser/permissions/permission_uma_util.cc
@@ -195,31 +195,35 @@ void PermissionUmaUtil::PermissionRequested(PermissionType permission,
 }
 
 void PermissionUmaUtil::PermissionGranted(PermissionType permission,
+                                          bool user_gesture,
                                           const GURL& requesting_origin,
                                           Profile* profile) {
   RecordPermissionAction(permission, GRANTED, PermissionSourceUI::PROMPT,
-                         requesting_origin, profile);
+                         user_gesture, requesting_origin, profile);
 }
 
 void PermissionUmaUtil::PermissionDenied(PermissionType permission,
+                                         bool user_gesture,
                                          const GURL& requesting_origin,
                                          Profile* profile) {
   RecordPermissionAction(permission, DENIED, PermissionSourceUI::PROMPT,
-                         requesting_origin, profile);
+                         user_gesture, requesting_origin, profile);
 }
 
 void PermissionUmaUtil::PermissionDismissed(PermissionType permission,
+                                            bool user_gesture,
                                             const GURL& requesting_origin,
                                             Profile* profile) {
   RecordPermissionAction(permission, DISMISSED, PermissionSourceUI::PROMPT,
-                         requesting_origin, profile);
+                         user_gesture, requesting_origin, profile);
 }
 
 void PermissionUmaUtil::PermissionIgnored(PermissionType permission,
+                                          bool user_gesture,
                                           const GURL& requesting_origin,
                                           Profile* profile) {
   RecordPermissionAction(permission, IGNORED, PermissionSourceUI::PROMPT,
-                         requesting_origin, profile);
+                         user_gesture, requesting_origin, profile);
 }
 
 void PermissionUmaUtil::PermissionRevoked(PermissionType permission,
@@ -232,8 +236,8 @@ void PermissionUmaUtil::PermissionRevoked(PermissionType permission,
       permission == PermissionType::GEOLOCATION ||
       permission == PermissionType::AUDIO_CAPTURE ||
       permission == PermissionType::VIDEO_CAPTURE) {
-    RecordPermissionAction(permission, REVOKED, source_ui, revoked_origin,
-                           profile);
+    RecordPermissionAction(permission, REVOKED, source_ui,
+                           false /* user_gesture */, revoked_origin, profile);

[timvolodine, 2016/07/25 13:58:58]

is this because we don't have user gestures for revoke?

[stefanocs, 2016/07/25 14:22:05]

Yes, revocations can only be triggered when user changed the setting, not when
prompted. This is a different kind of user gesture that we don't need to record.

You can see the discussion here
https://codereview.chromium.org/2153133002/diff/380001/chrome/browser/permiss...

   }
 }
 
@@ -337,6 +341,7 @@ bool PermissionUmaUtil::IsOptedIntoPermissionActionReporting(Profile* profile) {
 void PermissionUmaUtil::RecordPermissionAction(PermissionType permission,
                                                PermissionAction action,
                                                PermissionSourceUI source_ui,
+                                               bool user_gesture,

[timvolodine, 2016/07/25 13:58:58]

so this is passed but not used? am I missing something?

[stefanocs, 2016/07/25 14:22:05]

Oh right, I missed this one, this should be passed to PermissionReporter below.
I will change this tomorrow morning.

[stefanocs, 2016/07/26 00:37:10]

Done.

                                                const GURL& requesting_origin,
                                                Profile* profile) {
   if (IsOptedIntoPermissionActionReporting(profile)) {