Add gesture type value from desktop prompt to permission report

chrome/browser/permissions/permission_uma_util.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/permissions/permission_uma_util.h"
 
 #include <utility>
 
 #include "base/command_line.h"
 #include "base/metrics/histogram_macros.h"
@@ skipping 177 matching lines @@
 // add new permission
 void PermissionUmaUtil::PermissionRequested(PermissionType permission,
                                             const GURL& requesting_origin,
                                             const GURL& embedding_origin,
                                             Profile* profile) {
   RecordPermissionRequest(permission, requesting_origin, embedding_origin,
                           profile);
 }
 
 void PermissionUmaUtil::PermissionGranted(PermissionType permission,
+                                          bool user_gesture,
                                           const GURL& requesting_origin,
                                           Profile* profile) {
   RecordPermissionAction(permission, GRANTED, PermissionSourceUI::PROMPT,
-                         requesting_origin, profile);
+                         user_gesture, requesting_origin, profile);
 }
 
 void PermissionUmaUtil::PermissionDenied(PermissionType permission,
+                                         bool user_gesture,
                                          const GURL& requesting_origin,
                                          Profile* profile) {
   RecordPermissionAction(permission, DENIED, PermissionSourceUI::PROMPT,
-                         requesting_origin, profile);
+                         user_gesture, requesting_origin, profile);
 }
 
 void PermissionUmaUtil::PermissionDismissed(PermissionType permission,
+                                            bool user_gesture,
                                             const GURL& requesting_origin,
                                             Profile* profile) {
   RecordPermissionAction(permission, DISMISSED, PermissionSourceUI::PROMPT,
-                         requesting_origin, profile);
+                         user_gesture, requesting_origin, profile);
 }
 
 void PermissionUmaUtil::PermissionIgnored(PermissionType permission,
+                                          bool user_gesture,
                                           const GURL& requesting_origin,
                                           Profile* profile) {
   RecordPermissionAction(permission, IGNORED, PermissionSourceUI::PROMPT,
-                         requesting_origin, profile);
+                         user_gesture, requesting_origin, profile);
 }
 
 void PermissionUmaUtil::PermissionRevoked(PermissionType permission,
                                           PermissionSourceUI source_ui,
                                           const GURL& revoked_origin,
                                           Profile* profile) {
   // TODO(tsergeant): Expand metrics definitions for revocation to include all
   // permissions.
   if (permission == PermissionType::NOTIFICATIONS ||
       permission == PermissionType::GEOLOCATION ||
       permission == PermissionType::AUDIO_CAPTURE ||
       permission == PermissionType::VIDEO_CAPTURE) {
-    RecordPermissionAction(permission, REVOKED, source_ui, revoked_origin,
-                           profile);
+    RecordPermissionAction(permission, REVOKED, source_ui,
+                           false /* user_gesture */, revoked_origin, profile);

[timvolodine, 2016/07/25 13:58:58]

is this because we don't have user gestures for revoke?

[stefanocs, 2016/07/25 14:22:05]

Yes, revocations can only be triggered when user changed the setting, not when
prompted. This is a different kind of user gesture that we don't need to record.

You can see the discussion here
https://codereview.chromium.org/2153133002/diff/380001/chrome/browser/permiss...

   }
 }
 
 void PermissionUmaUtil::PermissionPromptShown(
     const std::vector<PermissionRequest*>& requests) {
   DCHECK(!requests.empty());
 
   PermissionRequestType permission_prompt_type =
       PermissionRequestType::MULTIPLE;
   if (requests.size() == 1)
@@ skipping 83 matching lines @@
     return false;
   if (!preferred_data_types.Has(syncer::PRIORITY_PREFERENCES))
     return false;
 
   return true;
 }
 
 void PermissionUmaUtil::RecordPermissionAction(PermissionType permission,
                                                PermissionAction action,
                                                PermissionSourceUI source_ui,
+                                               bool user_gesture,

[timvolodine, 2016/07/25 13:58:58]

so this is passed but not used? am I missing something?

[stefanocs, 2016/07/25 14:22:05]

Oh right, I missed this one, this should be passed to PermissionReporter below.
I will change this tomorrow morning.

[stefanocs, 2016/07/26 00:37:10]

Done.

                                                const GURL& requesting_origin,
                                                Profile* profile) {
   if (IsOptedIntoPermissionActionReporting(profile)) {
     // TODO(stefanocs): Add browsertests to make sure the reports are being
     // sent.
     // TODO(stefanocs): Get the actual |user_gesture| from permission layer.
     g_browser_process->safe_browsing_service()
         ->ui_manager()
         ->ReportPermissionAction(requesting_origin, permission, action,
                                  source_ui, false /* user_gesture */);
@@ skipping 69 matching lines @@
   if (!deprecated_metric.empty() && rappor_service) {
     rappor::SampleDomainAndRegistryFromGURL(rappor_service, deprecated_metric,
                                             requesting_origin);
 
     std::string rappor_metric = deprecated_metric + "2";
     rappor_service->RecordSample(
         rappor_metric, rappor::LOW_FREQUENCY_ETLD_PLUS_ONE_RAPPOR_TYPE,
         rappor::GetDomainAndRegistrySampleFromGURL(requesting_origin));
   }
 }