Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Unified Diff: chrome/browser/permissions/permission_uma_util.cc

Issue 2153133002: Add gesture type value from desktop prompt to permission report (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add-user-gesture-to-reporting-part
Patch Set: nit: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_uma_util.cc
diff --git a/chrome/browser/permissions/permission_uma_util.cc b/chrome/browser/permissions/permission_uma_util.cc
index 0206a20695e3b9d491a9a99ad443ee881136847c..b5830f053a32620140505d32a90b1fb8c98a9bba 100644
--- a/chrome/browser/permissions/permission_uma_util.cc
+++ b/chrome/browser/permissions/permission_uma_util.cc
@@ -195,31 +195,35 @@ void PermissionUmaUtil::PermissionRequested(PermissionType permission,
}
void PermissionUmaUtil::PermissionGranted(PermissionType permission,
+ bool user_gesture,
const GURL& requesting_origin,
Profile* profile) {
RecordPermissionAction(permission, GRANTED, PermissionSourceUI::PROMPT,
- requesting_origin, profile);
+ user_gesture, requesting_origin, profile);
}
void PermissionUmaUtil::PermissionDenied(PermissionType permission,
+ bool user_gesture,
const GURL& requesting_origin,
Profile* profile) {
RecordPermissionAction(permission, DENIED, PermissionSourceUI::PROMPT,
- requesting_origin, profile);
+ user_gesture, requesting_origin, profile);
}
void PermissionUmaUtil::PermissionDismissed(PermissionType permission,
+ bool user_gesture,
const GURL& requesting_origin,
Profile* profile) {
RecordPermissionAction(permission, DISMISSED, PermissionSourceUI::PROMPT,
- requesting_origin, profile);
+ user_gesture, requesting_origin, profile);
}
void PermissionUmaUtil::PermissionIgnored(PermissionType permission,
+ bool user_gesture,
const GURL& requesting_origin,
Profile* profile) {
RecordPermissionAction(permission, IGNORED, PermissionSourceUI::PROMPT,
- requesting_origin, profile);
+ user_gesture, requesting_origin, profile);
}
void PermissionUmaUtil::PermissionRevoked(PermissionType permission,
@@ -232,8 +236,8 @@ void PermissionUmaUtil::PermissionRevoked(PermissionType permission,
permission == PermissionType::GEOLOCATION ||
permission == PermissionType::AUDIO_CAPTURE ||
permission == PermissionType::VIDEO_CAPTURE) {
- RecordPermissionAction(permission, REVOKED, source_ui, revoked_origin,
- profile);
+ RecordPermissionAction(permission, REVOKED, source_ui,
+ true /* user_gesture */, revoked_origin, profile);
}
}
@@ -334,6 +338,7 @@ bool PermissionUmaUtil::IsOptedIntoPermissionActionReporting(Profile* profile) {
void PermissionUmaUtil::RecordPermissionAction(PermissionType permission,
PermissionAction action,
PermissionSourceUI source_ui,
+ bool user_gesture,
const GURL& requesting_origin,
Profile* profile) {
if (IsOptedIntoPermissionActionReporting(profile)) {

Powered by Google App Engine
This is Rietveld 408576698