Chromium Code Reviews| Index: chrome/browser/permissions/permission_queue_controller.cc |
| diff --git a/chrome/browser/permissions/permission_queue_controller.cc b/chrome/browser/permissions/permission_queue_controller.cc |
| index 161e04a10e95ba1f9aa7e04b4566b523cd91aa17..fca591323a0cf82bc5ff096e96bb7b90140bd440 100644 |
| --- a/chrome/browser/permissions/permission_queue_controller.cc |
| +++ b/chrome/browser/permissions/permission_queue_controller.cc |
| @@ -206,17 +206,20 @@ void PermissionQueueController::OnPermissionSet( |
| // TODO(miguelg): move the permission persistence to |
| // PermissionContextBase once all the types are moved there. |
| + // TODO(stefanocs): Pass the actual |user_gesture| value to PermissionUmaUtil. |
| if (update_content_setting) { |
| UpdateContentSetting(requesting_frame, embedder, allowed); |
| if (allowed) |
|
raymes
2016/07/18 07:31:59
nit add {}
stefanocs
2016/07/18 07:40:26
Done.
|
| - PermissionUmaUtil::PermissionGranted(permission_type_, requesting_frame, |
| - profile_); |
| + PermissionUmaUtil::PermissionGranted(permission_type_, |
| + false /* user_gesture */, |
| + requesting_frame, profile_); |
| else |
| - PermissionUmaUtil::PermissionDenied(permission_type_, requesting_frame, |
| - profile_); |
| + PermissionUmaUtil::PermissionDenied(permission_type_, |
| + false /* user_gesture */, |
| + requesting_frame, profile_); |
| } else { |
| - PermissionUmaUtil::PermissionDismissed(permission_type_, requesting_frame, |
| - profile_); |
| + PermissionUmaUtil::PermissionDismissed( |
| + permission_type_, false /* user_gesture */, requesting_frame, profile_); |
| } |
| // Cancel this request first, then notify listeners. TODO(pkasting): Why |