chrome/browser/permissions/permission_bubble_request_impl.h - Issue 2153133002: Add gesture type value from desktop prompt to permission report

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/permissions/permission_bubble_request_impl.h

Issue 2153133002: Add gesture type value from desktop prompt to permission report (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add-user-gesture-to-reporting-part

Patch Set: nit: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/media/media_stream_devices_controller.cc ('K') | « chrome/browser/media/media_stream_devices_controller.cc ('k') | chrome/browser/permissions/permission_bubble_request_impl.cc » ('j') | chrome/browser/permissions/permission_queue_controller.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/permissions/permission_bubble_request_impl.h

diff --git a/chrome/browser/permissions/permission_bubble_request_impl.h b/chrome/browser/permissions/permission_bubble_request_impl.h

index c78cd0785fff3dab3f7a83651bf5f7b581312961..eb899eef01eb9bc4dfa1ff5a54e933e11321b675 100644

--- a/chrome/browser/permissions/permission_bubble_request_impl.h

+++ b/chrome/browser/permissions/permission_bubble_request_impl.h

@@ -26,6 +26,7 @@ class PermissionBubbleRequestImpl : public PermissionBubbleRequest {

PermissionBubbleRequestImpl(

const GURL& request_origin,

content::PermissionType permission_type,

+ bool user_gesture,

Profile* profile,

const PermissionDecidedCallback& permission_decided_callback,

const base::Closure delete_callback);

@@ -51,6 +52,7 @@ class PermissionBubbleRequestImpl : public PermissionBubbleRequest {

GURL request_origin_;

content::PermissionType permission_type_;

+ bool user_gesture_;

raymes 2016/07/18 07:31:59 nit: perhaps add a comment that this is specifying

stefanocs 2016/07/18 11:13:34 Done.

Profile* profile_;

// Called once a decision is made about the permission.