Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/permissions/permission_queue_controller.cc

Issue 2153133002: Add gesture type value from desktop prompt to permission report (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add-user-gesture-to-reporting-part
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/permissions/permission_infobar_delegate.cc ('K') | « chrome/browser/permissions/permission_infobar_delegate.cc ('k') | chrome/browser/permissions/permission_uma_util.h » ('j') | chrome/browser/push_messaging/push_messaging_permission_context.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/permissions/permission_queue_controller.cc
diff --git a/chrome/browser/permissions/permission_queue_controller.cc b/chrome/browser/permissions/permission_queue_controller.cc
index 161e04a10e95ba1f9aa7e04b4566b523cd91aa17..301dd4821bc846d85cac69116ff6f972ab6e8fe4 100644
--- a/chrome/browser/permissions/permission_queue_controller.cc
+++ b/chrome/browser/permissions/permission_queue_controller.cc
@@ -206,17 +206,20 @@ void PermissionQueueController::OnPermissionSet(
// TODO(miguelg): move the permission persistence to
// PermissionContextBase once all the types are moved there.
+ // TODO(stefanocs): Pass the actual user_gesture value to PermissionUmaUtil.
if (update_content_setting) {
UpdateContentSetting(requesting_frame, embedder, allowed);
if (allowed)
raymes 2016/07/18 00:58:43 nit: add {}
stefanocs 2016/07/18 04:28:45 Done.
- PermissionUmaUtil::PermissionGranted(permission_type_, requesting_frame,
- profile_);
+ PermissionUmaUtil::PermissionGranted(permission_type_,
+ false /* user_gesture */,
+ requesting_frame, profile_);
else
raymes 2016/07/18 00:58:43 nit: add {}
stefanocs 2016/07/18 04:28:45 Done.
- PermissionUmaUtil::PermissionDenied(permission_type_, requesting_frame,
- profile_);
+ PermissionUmaUtil::PermissionDenied(permission_type_,
+ false /* user_gesture */,
+ requesting_frame, profile_);
} else {
- PermissionUmaUtil::PermissionDismissed(permission_type_, requesting_frame,
- profile_);
+ PermissionUmaUtil::PermissionDismissed(
+ permission_type_, false /* user_gesture */, requesting_frame, profile_);
}
// Cancel this request first, then notify listeners. TODO(pkasting): Why
« chrome/browser/permissions/permission_infobar_delegate.cc ('K') | « chrome/browser/permissions/permission_infobar_delegate.cc ('k') | chrome/browser/permissions/permission_uma_util.h » ('j') | chrome/browser/push_messaging/push_messaging_permission_context.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698