chrome/browser/permissions/permission_infobar_delegate.cc - Issue 2153133002: Add gesture type value from desktop prompt to permission report

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/permissions/permission_infobar_delegate.cc

Issue 2153133002: Add gesture type value from desktop prompt to permission report (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add-user-gesture-to-reporting-part

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/permissions/permission_context_base.cc ('K') | « chrome/browser/permissions/permission_context_base.cc ('k') | chrome/browser/permissions/permission_queue_controller.cc » ('j') | chrome/browser/permissions/permission_queue_controller.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/permissions/permission_infobar_delegate.cc

diff --git a/chrome/browser/permissions/permission_infobar_delegate.cc b/chrome/browser/permissions/permission_infobar_delegate.cc

index 5300e7e4c28de326a9bdfb966f6fd9122fc20e04..ab005677ba76247e81bc8fd0278da2c71b0372f2 100644

--- a/chrome/browser/permissions/permission_infobar_delegate.cc

+++ b/chrome/browser/permissions/permission_infobar_delegate.cc

@@ -11,9 +11,11 @@

#include "ui/base/l10n/l10n_util.h"

PermissionInfobarDelegate::~PermissionInfobarDelegate() {

+ // TODO(stefanocs): Pass the actual user_gesture value to PermissionUmaUtil.

raymes 2016/07/18 00:58:43 |user_gesture|

stefanocs 2016/07/18 04:28:45 Done.

if (!action_taken_)

raymes 2016/07/18 00:58:43 nit: add {}

stefanocs 2016/07/18 04:28:45 Done.

- PermissionUmaUtil::PermissionIgnored(permission_type_, requesting_origin_,

- profile_);

+ PermissionUmaUtil::PermissionIgnored(permission_type_,

+ false /* user_gesture */,

+ requesting_origin_, profile_);

}

PermissionInfobarDelegate::PermissionInfobarDelegate(