Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Side by Side Diff: chrome/browser/permissions/permission_infobar_delegate.cc

Issue 2153133002: Add gesture type value from desktop prompt to permission report (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add-user-gesture-to-reporting-part
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/permissions/permission_infobar_delegate.h" 5 #include "chrome/browser/permissions/permission_infobar_delegate.h"
6 6
7 #include "chrome/browser/permissions/permission_uma_util.h" 7 #include "chrome/browser/permissions/permission_uma_util.h"
8 #include "chrome/grit/generated_resources.h" 8 #include "chrome/grit/generated_resources.h"
9 #include "components/infobars/core/infobar.h" 9 #include "components/infobars/core/infobar.h"
10 #include "components/url_formatter/elide_url.h" 10 #include "components/url_formatter/elide_url.h"
11 #include "ui/base/l10n/l10n_util.h" 11 #include "ui/base/l10n/l10n_util.h"
12 12
13 PermissionInfobarDelegate::~PermissionInfobarDelegate() { 13 PermissionInfobarDelegate::~PermissionInfobarDelegate() {
14 // TODO(stefanocs): Pass the actual user_gesture value to PermissionUmaUtil.
raymes 2016/07/18 00:58:43 |user_gesture|
stefanocs 2016/07/18 04:28:45 Done.
14 if (!action_taken_) 15 if (!action_taken_)
raymes 2016/07/18 00:58:43 nit: add {}
stefanocs 2016/07/18 04:28:45 Done.
15 PermissionUmaUtil::PermissionIgnored(permission_type_, requesting_origin_, 16 PermissionUmaUtil::PermissionIgnored(permission_type_,
16 profile_); 17 false /* user_gesture */,
18 requesting_origin_, profile_);
17 } 19 }
18 20
19 PermissionInfobarDelegate::PermissionInfobarDelegate( 21 PermissionInfobarDelegate::PermissionInfobarDelegate(
20 const GURL& requesting_origin, 22 const GURL& requesting_origin,
21 content::PermissionType permission_type, 23 content::PermissionType permission_type,
22 ContentSettingsType content_settings_type, 24 ContentSettingsType content_settings_type,
23 Profile* profile, 25 Profile* profile,
24 const base::Callback<void(bool, bool)>& callback) 26 const base::Callback<void(bool, bool)>& callback)
25 : requesting_origin_(requesting_origin), 27 : requesting_origin_(requesting_origin),
26 action_taken_(false), 28 action_taken_(false),
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
65 bool PermissionInfobarDelegate::Cancel() { 67 bool PermissionInfobarDelegate::Cancel() {
66 SetPermission(true, false); 68 SetPermission(true, false);
67 return true; 69 return true;
68 } 70 }
69 71
70 void PermissionInfobarDelegate::SetPermission(bool update_content_setting, 72 void PermissionInfobarDelegate::SetPermission(bool update_content_setting,
71 bool allowed) { 73 bool allowed) {
72 action_taken_ = true; 74 action_taken_ = true;
73 callback_.Run(update_content_setting, allowed); 75 callback_.Run(update_content_setting, allowed);
74 } 76 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698