Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 2153113002: Remove constructor from functions that aren't constructors (Closed)

Created:
4 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 5 months ago
Reviewers:
haraken, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@2743
Target Ref:
refs/heads/chromium/2743
Project:
pdfium
Visibility:
Public.

Description

Remove constructor from functions that aren't constructors BUG=chromium:625823 TBR=haraken@chromium.org,thestig@chromium.org Review-Url: https://codereview.chromium.org/2128793002 (cherry picked from commit 3c27a84d15c06f85cc7f455f96dc124673f9f9d2) Committed: https://pdfium.googlesource.com/pdfium/+/6dceb53484b65aa73c2ebc25bbd83c59e1cd5b18

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M DEPS View 1 chunk +2 lines, -2 lines 0 comments Download
M build_gyp/standalone.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/fxjse/dynprop.cpp View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
jochen (gone - plz use gerrit)
Committed patchset #1 (id:1) manually as 6dceb53484b65aa73c2ebc25bbd83c59e1cd5b18 (tree was closed).
4 years, 5 months ago (2016-07-15 11:41:06 UTC) #2
haraken
4 years, 5 months ago (2016-07-15 13:48:41 UTC) #3
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698