gyp: url_mojom should be a hard_dependency

gyp: url_mojom should be a hard_dependency

The url/url.gyp:url_mojom target depends on url_interfaces_mojom,
which generates header files, and sets itself as a
hard_dependency.  Thhat hard_dependency status is not propagated
to url_mojom. Let's add it explicitly.

Committed: https://crrev.com/9769d7ca93be00c5a0891ef01e07c7afbafa55d8
Cr-Commit-Position: refs/heads/master@{#405794}

[Mostyn Bramley-Moore, 2016-07-15 10:45:58]

mostynb@opera.com changed reviewers:
+ brettw@chromium.org, mek@chromium.org

[Mostyn Bramley-Moore, 2016-07-15 10:45:58]

@brettw: I am trying to fix some gyp build flakiness after CL2004643002 landed-
can you confirm my diagnosis of the cause?

The symptom is that when compiling
gen/components/webmessaging/public/interfaces/broadcast_channel.mojom-blink.cc,
broadcast_channel.mojom-blink-internal.h includes
url/mojo/origin.mojom-blink-internal.h which does not (yet) exist.

@mek: FYI.

[Mostyn Bramley-Moore, 2016-07-15 10:46:34]

The CQ bit was checked by mostynb@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-15 10:46:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 11:24:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 11:24:16]

Dry run: This issue passed the CQ dry run.

[Mostyn Bramley-Moore, 2016-07-15 12:06:08]

Actually, it seems that this problem only occurs with
https://codereview.chromium.org/2136523002/ applied, and it doesn't look like
that will land.  But perhaps this is still valid fix?

[Mostyn Bramley-Moore, 2016-07-15 12:07:19]

Description was changed from

==========
fix gyp build flakiness in components/webmessaging

The webmessaging_mojo_bindings_for_blink target depends on
url/url.gyp:url_mojom which in turn depends on url_interfaces_mojom.
url_interfaces_mojom generates header files, and sets itself as a
hard_dependency, but it seems that this hard_dependency status is
not propagated to url_mojom. Let's add it explicitly.

BUG=161070
==========

to

==========
gyp: url_mojom should be a hard_dependency

The url/url.gyp:url_mojom target depends on url_interfaces_mojom, which
generates header files, and sets itself as a
hard_dependency, but it seems that this hard_dependency status is
not propagated to url_mojom. Let's add it explicitly.
==========

[Mostyn Bramley-Moore, 2016-07-15 12:07:46]

Description was changed from

==========
gyp: url_mojom should be a hard_dependency

The url/url.gyp:url_mojom target depends on url_interfaces_mojom, which
generates header files, and sets itself as a
hard_dependency, but it seems that this hard_dependency status is
not propagated to url_mojom. Let's add it explicitly.
==========

to

==========
gyp: url_mojom should be a hard_dependency

The url/url.gyp:url_mojom target depends on url_interfaces_mojom,
which generates header files, and sets itself as a
hard_dependency, but it seems that this hard_dependency status is
not propagated to url_mojom. Let's add it explicitly.
==========

[jaredw, 2016-07-15 15:53:25]

On 2016/07/15 12:06:08, Mostyn Bramley-Moore wrote:
> Actually, it seems that this problem only occurs with
> https://codereview.chromium.org/2136523002/ applied, and it doesn't look like
> that will land.  But perhaps this is still valid fix?

I am getting the error about this missing header file just using automate-git.py
building from the master.

[brettw, 2016-07-15 17:03:40]

lgtm

https://codereview.chromium.org/2153093002/diff/1/url/url.gyp
File url/url.gyp (right):

https://codereview.chromium.org/2153093002/diff/1/url/url.gyp#newcode144
url/url.gyp:144: # It seems that this hard dependency status is not propagated
to
Just remove "it seems" because GYP does indeed not automaticall propagate hard
dependency flags.

[Mostyn Bramley-Moore, 2016-07-15 17:29:29]

Description was changed from

==========
gyp: url_mojom should be a hard_dependency

The url/url.gyp:url_mojom target depends on url_interfaces_mojom,
which generates header files, and sets itself as a
hard_dependency, but it seems that this hard_dependency status is
not propagated to url_mojom. Let's add it explicitly.
==========

to

==========
gyp: url_mojom should be a hard_dependency

The url/url.gyp:url_mojom target depends on url_interfaces_mojom,
which generates header files, and sets itself as a
hard_dependency.  Thhat hard_dependency status is not propagated
to url_mojom. Let's add it explicitly.
==========

[Mostyn Bramley-Moore, 2016-07-15 17:29:43]

https://codereview.chromium.org/2153093002/diff/1/url/url.gyp
File url/url.gyp (right):

https://codereview.chromium.org/2153093002/diff/1/url/url.gyp#newcode144
url/url.gyp:144: # It seems that this hard dependency status is not propagated
to
On 2016/07/15 17:03:40, brettw (ping after 24h) wrote:
> Just remove "it seems" because GYP does indeed not automaticall propagate hard
> dependency flags.

Done.

[Mostyn Bramley-Moore, 2016-07-15 17:31:18]

The CQ bit was checked by mostynb@opera.com

[Mostyn Bramley-Moore, 2016-07-15 17:31:18]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/2153093002/#ps20001
(title: "adjust comment")

[commit-bot: I haz the power, 2016-07-15 17:32:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 18:16:57]

Description was changed from

==========
gyp: url_mojom should be a hard_dependency

The url/url.gyp:url_mojom target depends on url_interfaces_mojom,
which generates header files, and sets itself as a
hard_dependency.  Thhat hard_dependency status is not propagated
to url_mojom. Let's add it explicitly.
==========

to

==========
gyp: url_mojom should be a hard_dependency

The url/url.gyp:url_mojom target depends on url_interfaces_mojom,
which generates header files, and sets itself as a
hard_dependency.  Thhat hard_dependency status is not propagated
to url_mojom. Let's add it explicitly.
==========

[commit-bot: I haz the power, 2016-07-15 18:16:58]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-15 18:19:00]

Description was changed from

==========
gyp: url_mojom should be a hard_dependency

The url/url.gyp:url_mojom target depends on url_interfaces_mojom,
which generates header files, and sets itself as a
hard_dependency.  Thhat hard_dependency status is not propagated
to url_mojom. Let's add it explicitly.
==========

to

==========
gyp: url_mojom should be a hard_dependency

The url/url.gyp:url_mojom target depends on url_interfaces_mojom,
which generates header files, and sets itself as a
hard_dependency.  Thhat hard_dependency status is not propagated
to url_mojom. Let's add it explicitly.

Committed: https://crrev.com/9769d7ca93be00c5a0891ef01e07c7afbafa55d8
Cr-Commit-Position: refs/heads/master@{#405794}
==========

[commit-bot: I haz the power, 2016-07-15 18:19:01]

Patchset 2 (id:??) landed as
https://crrev.com/9769d7ca93be00c5a0891ef01e07c7afbafa55d8
Cr-Commit-Position: refs/heads/master@{#405794}