Issue 2136523002: Don't depend on url_mojom_for_blink in the webmessaging target

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2136523002: Don't depend on url_mojom_for_blink in the webmessaging target (Closed)

Created:
4 years, 5 months ago by robertn

Modified:
4 years, 5 months ago

Reviewers:
Marshall, Marijn Kruisselbrink

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Don't depend on url_mojom_for_blink in the webmessaging target Depend on url.gyp:url_mojom instead. BUG=626150 R=mek@chromium.org,marshall@chromium.org

Patch Set 1 #

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -6 lines)			Patch
	M	components/webmessaging.gypi	View		2 chunks	+7 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

robertn

On 2016/07/08 13:20:51, robertn wrote: Just noticed that doing it like this doesn't seem to ...

4 years, 5 months ago (2016-07-08 14:16:14 UTC) #4

Marijn Kruisselbrink

4 years, 5 months ago (2016-07-08 16:41:28 UTC) #5

On 2016/07/08 at 14:16:14, robertn wrote:
> On 2016/07/08 13:20:51, robertn wrote:
> 
> Just noticed that doing it like this doesn't seem to be sufficient after all -
this will cause some flakiness.

yeah, it definitely doesn't make any sense to depend on the non-blink url mojom
bindings from the blink webmessaging mojom bindings.

Also not sure exactly what configuration this is causing problems in (and if
that configuration is still a configuration we're even trying to support, with
all the migration from gyp to gn going on). Clearly it's at least a
configuration we don't have any bots for...

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages