Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2153013002: Added negative is check support ot simpleInstanceOf. (Closed)

Created:
4 years, 5 months ago by bakster
Modified:
4 years, 5 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Added negative is check support ot simpleInstanceOf. BUG= R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/d59f3eaeca79eb93e9c44d0f8d7825c53bd3ceb3

Patch Set 1 #

Patch Set 2 : Added missing line. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -29 lines) Patch
M runtime/vm/flow_graph_builder.cc View 1 3 chunks +33 lines, -29 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
bakster
4 years, 5 months ago (2016-07-15 00:17:32 UTC) #2
bakster
Ping!
4 years, 5 months ago (2016-07-18 16:14:23 UTC) #3
Florian Schneider
Lgtm
4 years, 5 months ago (2016-07-18 16:16:10 UTC) #4
bakster
4 years, 5 months ago (2016-07-18 16:20:39 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
d59f3eaeca79eb93e9c44d0f8d7825c53bd3ceb3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698