Added negative is check support ot simpleInstanceOf.

runtime/vm/flow_graph_builder.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/flow_graph_builder.h"
 
 #include "lib/invocation_mirror.h"
 #include "vm/ast_printer.h"
 #include "vm/bit_vector.h"
 #include "vm/compiler.h"
@@ skipping 1600 matching lines @@
         Object::null_array(),  // No argument names.
         kNumArgsChecked,
         owner()->ic_data_array());
     ReturnDefinition(call);
     return;
   }
 
   // We now know type is a real class (!num, !int, !smi, !string)
   // and the type check could NOT be removed at compile time.
   PushArgumentInstr* push_left = PushArgument(for_left_value.value());
-  if (simpleInstanceOfType(type) && (node->kind() == Token::kIS)) {
+  if (simpleInstanceOfType(type)) {
     ASSERT(!node->right()->AsTypeNode()->type().IsNull());
     ZoneGrowableArray<PushArgumentInstr*>* arguments =
         new(Z) ZoneGrowableArray<PushArgumentInstr*>(2);
     arguments->Add(push_left);
     Value* type_const = Bind(new(Z) ConstantInstr(type));
     arguments->Add(PushArgument(type_const));
     const intptr_t kNumArgsChecked = 2;
-    InstanceCallInstr* call = new(Z) InstanceCallInstr(
+    Definition* result = new(Z) InstanceCallInstr(
         node->token_pos(),
         Library::PrivateCoreLibName(Symbols::_simpleInstanceOf()),
         node->kind(),
         arguments,
         Object::null_array(),  // No argument names.
         kNumArgsChecked,
         owner()->ic_data_array());
-    ReturnDefinition(call);
+    if (negate_result) {
+      result = new(Z) BooleanNegateInstr(Bind(result));
+    }
+    ReturnDefinition(result);
+    return;
+  }
+
+  PushArgumentInstr* push_type_args = NULL;
+  if (type.IsInstantiated()) {
+    push_type_args = PushArgument(BuildNullValue(node->token_pos()));
   } else {
-    PushArgumentInstr* push_type_args = NULL;
-    if (type.IsInstantiated()) {
-      push_type_args = PushArgument(BuildNullValue(node->token_pos()));
-    } else {
-      BuildTypecheckPushArguments(node->token_pos(), &push_type_args);
-    }
-    ZoneGrowableArray<PushArgumentInstr*>* arguments =
-        new(Z) ZoneGrowableArray<PushArgumentInstr*>(4);
-    arguments->Add(push_left);
-    arguments->Add(push_type_args);
-    ASSERT(!node->right()->AsTypeNode()->type().IsNull());
-    Value* type_const = Bind(new(Z) ConstantInstr(type));
-    arguments->Add(PushArgument(type_const));
-    const Bool& negate = Bool::Get(node->kind() == Token::kISNOT);
-    Value* negate_arg = Bind(new(Z) ConstantInstr(negate));
-    arguments->Add(PushArgument(negate_arg));
-    const intptr_t kNumArgsChecked = 1;
-    InstanceCallInstr* call = new(Z) InstanceCallInstr(
-        node->token_pos(),
-        Library::PrivateCoreLibName(Symbols::_instanceOf()),
-        node->kind(),
-        arguments,
-        Object::null_array(),  // No argument names.
-        kNumArgsChecked,
-        owner()->ic_data_array());
-    ReturnDefinition(call);
+    BuildTypecheckPushArguments(node->token_pos(), &push_type_args);
   }
+  ZoneGrowableArray<PushArgumentInstr*>* arguments =
+      new(Z) ZoneGrowableArray<PushArgumentInstr*>(4);
+  arguments->Add(push_left);
+  arguments->Add(push_type_args);
+  ASSERT(!node->right()->AsTypeNode()->type().IsNull());
+  Value* type_const = Bind(new(Z) ConstantInstr(type));
+  arguments->Add(PushArgument(type_const));
+  const Bool& negate = Bool::Get(node->kind() == Token::kISNOT);
+  Value* negate_arg = Bind(new(Z) ConstantInstr(negate));
+  arguments->Add(PushArgument(negate_arg));
+  const intptr_t kNumArgsChecked = 1;
+  InstanceCallInstr* call = new(Z) InstanceCallInstr(
+      node->token_pos(),
+      Library::PrivateCoreLibName(Symbols::_instanceOf()),
+      node->kind(),
+      arguments,
+      Object::null_array(),  // No argument names.
+      kNumArgsChecked,
+      owner()->ic_data_array());
+  ReturnDefinition(call);
 }
 
 
 void EffectGraphVisitor::BuildTypeCast(ComparisonNode* node) {
   ASSERT(Token::IsTypeCastOperator(node->kind()));
   ASSERT(!node->right()->AsTypeNode()->type().IsNull());
   const AbstractType& type = node->right()->AsTypeNode()->type();
   ASSERT(type.IsFinalized() && !type.IsMalformed() && !type.IsMalbounded());
   ValueGraphVisitor for_value(owner());
   node->left()->Visit(&for_value);
@@ skipping 2942 matching lines @@
                                               block_marks);
   ASSERT(found);
 }
 
 
 void FlowGraphBuilder::Bailout(const char* reason) const {
   parsed_function_.Bailout("FlowGraphBuilder", reason);
 }
 
 }  // namespace dart