Issue 2152823004: [Material][Mac] Animation for Omnibox Verbose State Chips

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2152823004: [Material][Mac] Animation for Omnibox Verbose State Chips (Closed)

Created:
4 years, 5 months ago by spqchan

Modified:
4 years, 4 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Material][Mac] Animation for Omnibox Verbose State Chips BUG=

Patch Set 1 #

Patch Set 2 : Debug in progress #

Patch Set 3 : Fixed an animation miscalculation #

Patch Set 4 : Fixed transformation origin #

Patch Set 5 : Fixed the yOffset and divider #

Patch Set 6 : Cleaning up #

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+566 lines, -76 lines)			Patch
M	chrome/browser/ui/cocoa/location_bar/bubble_decoration.h	View	1 2 3 4 5	3 chunks	+7 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/cocoa/location_bar/bubble_decoration.mm	View	1 2 3 4 5	3 chunks	+19 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/cocoa/location_bar/ev_bubble_decoration.h	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/location_bar/ev_bubble_decoration.mm	View		2 chunks	+3 lines, -13 lines	0 comments	Download
M	chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h	View		3 chunks	+15 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm	View	1 2 3 4 5	15 chunks	+63 lines, -33 lines	0 comments	Download
A	chrome/browser/ui/cocoa/location_bar/secure_verbose_bubble_decoration.h	View	1 2 3 4 5	1 chunk	+59 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/cocoa/location_bar/secure_verbose_bubble_decoration.mm	View	1 2 3 4 5	1 chunk	+347 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser_ui.gypi	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	components/omnibox_strings.grdp	View		1 chunk	+9 lines, -0 lines	0 comments	Download
M	components/toolbar/toolbar_model.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	components/toolbar/toolbar_model_impl.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	components/toolbar/toolbar_model_impl.cc	View		1 chunk	+16 lines, -0 lines	0 comments	Download
M	ui/gfx/animation/tween.h	View	1 2 3 4 5	1 chunk	+17 lines, -16 lines	0 comments	Download
M	ui/gfx/animation/tween.cc	View	1 2 3 4 5	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

spqchan

4 years, 5 months ago (2016-07-20 00:12:17 UTC) #1

Description was changed from

==========
Animation WIP

BUG=
==========

to

==========
[Material][Mac] Animation for Omnibox Verbose State Chips

BUG=
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages