Push: Update sender ID missing error messages for applicationServerKey

Push: Add applicationServerKey to sender ID missing error messages

The PUSH_REGISTRATION_STATUS_NO_SENDER_ID and
PUSH_REGISTRATION_STATUS_MANIFEST_EMPTY_OR_MISSING error messages
are misleading now that a key or sender ID can be provided via
applicationServerKey instead of the gcm_sender_id manifest
property. Updated error messages accordingly.

BUG=463113, 583753
Committed: https://crrev.com/cd4efe3e3063fdd2c8a387aea83fa71148d38ea0
Cr-Commit-Position: refs/heads/master@{#405788}

[johnme, 2016-07-15 14:57:36]

johnme@chromium.org changed reviewers:
+ peter@chromium.org

[Peter Beverloo, 2016-07-15 15:00:50]

lgtm

[johnme, 2016-07-15 15:15:10]

Description was changed from

==========
Push: Update sender ID missing error message for applicationServerKey

PUSH_REGISTRATION_STATUS_NO_SENDER_ID is misleading now that a key or
sender ID can be provided via applicationServerKey instead of the
gcm_sender_id manifest property. Updated error message accordingly.

BUG=463113,583753
==========

to

==========
Push: Add applicationServerKey to sender ID missing error messages

The PUSH_REGISTRATION_STATUS_NO_SENDER_ID and
PUSH_REGISTRATION_STATUS_MANIFEST_EMPTY_OR_MISSING error messages
are misleading now that a key or sender ID can be provided via
applicationServerKey instead of the gcm_sender_id manifest
property. Updated error messages accordingly.

BUG=463113,583753
==========

[johnme, 2016-07-15 15:15:36]

johnme@chromium.org changed reviewers:
+ avi@chromium.org

[johnme, 2016-07-15 15:15:36]

avi@chromium.org: Please approve content/public/common/push_messaging_status.cc
- thanks!

[Avi (use Gerrit), 2016-07-15 15:17:17]

lgtm

stampity stamp

[johnme, 2016-07-15 15:18:30]

The CQ bit was checked by johnme@chromium.org

[johnme, 2016-07-15 15:18:30]

The patchset sent to the CQ was uploaded after l-g-t-m from peter@chromium.org
Link to the patchset: https://codereview.chromium.org/2152823003/#ps20001
(title: "Also fix PUSH_REGISTRATION_STATUS_MANIFEST_EMPTY_OR_MISSING")

[commit-bot: I haz the power, 2016-07-15 15:19:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 18:00:13]

Description was changed from

==========
Push: Add applicationServerKey to sender ID missing error messages

The PUSH_REGISTRATION_STATUS_NO_SENDER_ID and
PUSH_REGISTRATION_STATUS_MANIFEST_EMPTY_OR_MISSING error messages
are misleading now that a key or sender ID can be provided via
applicationServerKey instead of the gcm_sender_id manifest
property. Updated error messages accordingly.

BUG=463113,583753
==========

to

==========
Push: Add applicationServerKey to sender ID missing error messages

The PUSH_REGISTRATION_STATUS_NO_SENDER_ID and
PUSH_REGISTRATION_STATUS_MANIFEST_EMPTY_OR_MISSING error messages
are misleading now that a key or sender ID can be provided via
applicationServerKey instead of the gcm_sender_id manifest
property. Updated error messages accordingly.

BUG=463113,583753
==========

[commit-bot: I haz the power, 2016-07-15 18:00:14]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-15 18:00:16]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-15 18:02:34]

Description was changed from

==========
Push: Add applicationServerKey to sender ID missing error messages

The PUSH_REGISTRATION_STATUS_NO_SENDER_ID and
PUSH_REGISTRATION_STATUS_MANIFEST_EMPTY_OR_MISSING error messages
are misleading now that a key or sender ID can be provided via
applicationServerKey instead of the gcm_sender_id manifest
property. Updated error messages accordingly.

BUG=463113,583753
==========

to

==========
Push: Add applicationServerKey to sender ID missing error messages

The PUSH_REGISTRATION_STATUS_NO_SENDER_ID and
PUSH_REGISTRATION_STATUS_MANIFEST_EMPTY_OR_MISSING error messages
are misleading now that a key or sender ID can be provided via
applicationServerKey instead of the gcm_sender_id manifest
property. Updated error messages accordingly.

BUG=463113,583753

Committed: https://crrev.com/cd4efe3e3063fdd2c8a387aea83fa71148d38ea0
Cr-Commit-Position: refs/heads/master@{#405788}
==========

[commit-bot: I haz the power, 2016-07-15 18:02:35]

Patchset 2 (id:??) landed as
https://crrev.com/cd4efe3e3063fdd2c8a387aea83fa71148d38ea0
Cr-Commit-Position: refs/heads/master@{#405788}