content/public/common/push_messaging_status.cc - Issue 2152823003: Push: Update sender ID missing error messages for applicationServerKey

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/common/push_messaging_status.cc

Issue 2152823003: Push: Update sender ID missing error messages for applicationServerKey (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Also fix PUSH_REGISTRATION_STATUS_MANIFEST_EMPTY_OR_MISSING Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/push_messaging/push_messaging_browsertest.cc ('k') | third_party/WebKit/LayoutTests/http/tests/push_messaging/subscribe-failure-no-manifest-in-service-worker.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/common/push_messaging_status.cc

diff --git a/content/public/common/push_messaging_status.cc b/content/public/common/push_messaging_status.cc

index b955bfce95c036b3626ebcbc7d293352401091f4..09a56f4be8645bb88ca4732f5964fb464166ad49 100644

--- a/content/public/common/push_messaging_status.cc

+++ b/content/public/common/push_messaging_status.cc

@@ -29,7 +29,8 @@ const char* PushRegistrationStatusToString(PushRegistrationStatus status) {

return "Registration failed - push service error";

case PUSH_REGISTRATION_STATUS_NO_SENDER_ID:

- return "Registration failed - gcm_sender_id not found in manifest";

+ return "Registration failed - missing applicationServerKey, and "

+ "gcm_sender_id not found in manifest";

case PUSH_REGISTRATION_STATUS_STORAGE_ERROR:

return "Registration failed - storage error";

@@ -49,7 +50,8 @@ const char* PushRegistrationStatusToString(PushRegistrationStatus status) {

return "Registration failed - could not retrieve the public key";

case PUSH_REGISTRATION_STATUS_MANIFEST_EMPTY_OR_MISSING:

- return "Registration failed - manifest empty or missing";

+ return "Registration failed - missing applicationServerKey, and manifest "

+ "empty or missing";

}

NOTREACHED();

return "";