Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2152803003: Avoid Context::Enter and Context::Exit if we're reentering the active and last entered context (Closed)

Created:
4 years, 5 months ago by Camillo Bruni
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of Avoid Context::Enter and Context::Exit if we're reentering the active and last entered context (patchset #1 id:1 of https://codereview.chromium.org/2140563002/ ) Reason for reland: https://codereview.chromium.org/2122953002 fixed context issues. Original issue's description: > Revert of Avoid Context::Enter and Context::Exit if we're reentering the active and last entered context (patchset #2 id:20001 of https://codereview.chromium.org/2131483002/ ) > > Reason for revert: > crashes: crbug.com/626719 > > Original issue's description: > > Avoid Context::Enter and Context::Exit if we're reentering the active and last entered context > > > > A bit of browsing around indicates that the new fast-path is taken most of the time: > > 3496 Entering new > > 152295 Reentering same > > > > BUG= > > > > Committed: https://crrev.com/1829eb661ef1cf432fb551bcb193f521a219d490 > > Cr-Commit-Position: refs/heads/master@{#37570} > > TBR=jochen@chromium.org,verwaest@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG= > > Committed: https://crrev.com/bec49a4876fdf8a20600ecdfc8534d0ef45c9528 > Cr-Commit-Position: refs/heads/master@{#37632} TBR=jochen@chromium.org,verwaest@chromium.org,jkummerow@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= Committed: https://crrev.com/1b44afe53720edc43c525ff92b212f76adb47170 Cr-Commit-Position: refs/heads/master@{#37778}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M src/api.cc View 1 chunk +11 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Camillo Bruni
Created Reland of Avoid Context::Enter and Context::Exit if we're reentering the active and last entered ...
4 years, 5 months ago (2016-07-14 16:26:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2152803003/1
4 years, 5 months ago (2016-07-14 16:27:15 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 16:58:08 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 17:00:40 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1b44afe53720edc43c525ff92b212f76adb47170
Cr-Commit-Position: refs/heads/master@{#37778}

Powered by Google App Engine
This is Rietveld 408576698