Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 2122953002: [crankshaft] do not restore rsi in stub for deferred number conversions (Closed)

Created:
4 years, 5 months ago by Camillo Bruni
Modified:
4 years, 5 months ago
Reviewers:
Jakob Kummerow
CC:
v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com, v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] do not restore rsi in stub for deferred number conversions BUG=v8:5188, chromium:626719 Committed: https://crrev.com/9aa8051f1a8f9b05be0decdb1b09729bc4f5c91e Cr-Commit-Position: refs/heads/master@{#37766}

Patch Set 1 #

Patch Set 2 : fixing DoDeferredNumberTagIU as well #

Patch Set 3 : adding additional validation #

Patch Set 4 : always reset the context register before calling AllocateHeapNumber #

Patch Set 5 : fixing wrong registers #

Total comments: 1

Patch Set 6 : addressing nit #

Patch Set 7 : rebase onto master #

Patch Set 8 : fixing register overlap on arm64 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -143 lines) Patch
M src/arguments.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M src/builtins/builtins.cc View 1 2 3 4 5 6 1 chunk +24 lines, -23 lines 0 comments Download
M src/crankshaft/arm/lithium-codegen-arm.cc View 1 2 3 4 5 6 2 chunks +8 lines, -13 lines 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.cc View 1 2 3 4 5 6 7 5 chunks +11 lines, -16 lines 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.cc View 1 2 3 4 5 6 2 chunks +8 lines, -13 lines 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.cc View 1 2 3 4 5 6 7 2 chunks +8 lines, -13 lines 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 1 2 3 4 5 6 2 chunks +8 lines, -13 lines 0 comments Download
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 1 2 3 4 5 6 2 chunks +8 lines, -13 lines 0 comments Download
M src/crankshaft/s390/lithium-codegen-s390.cc View 1 2 3 4 5 6 2 chunks +8 lines, -13 lines 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.cc View 1 2 3 4 5 6 2 chunks +8 lines, -13 lines 0 comments Download
M src/crankshaft/x87/lithium-codegen-x87.cc View 1 2 3 4 5 6 2 chunks +8 lines, -13 lines 0 comments Download

Messages

Total messages: 34 (23 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2122953002/1
4 years, 5 months ago (2016-07-07 09:45:27 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/builds/4549) v8_linux_nodcheck_rel_ng_triggered on ...
4 years, 5 months ago (2016-07-07 10:02:12 UTC) #5
Camillo Bruni
PTAL
4 years, 5 months ago (2016-07-13 15:49:13 UTC) #13
Jakob Kummerow
LGTM with nit https://codereview.chromium.org/2122953002/diff/80001/src/crankshaft/ia32/lithium-codegen-ia32.cc File src/crankshaft/ia32/lithium-codegen-ia32.cc (right): https://codereview.chromium.org/2122953002/diff/80001/src/crankshaft/ia32/lithium-codegen-ia32.cc#newcode4412 src/crankshaft/ia32/lithium-codegen-ia32.cc:4412: // Smi to XMM conversion. Clobbering ...
4 years, 5 months ago (2016-07-13 15:56:56 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2122953002/100001
4 years, 5 months ago (2016-07-14 07:54:10 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/builds/4960) v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED, ...
4 years, 5 months ago (2016-07-14 07:55:41 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2122953002/120001
4 years, 5 months ago (2016-07-14 08:13:06 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel/builds/17727)
4 years, 5 months ago (2016-07-14 08:19:35 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2122953002/140001
4 years, 5 months ago (2016-07-14 13:39:52 UTC) #31
commit-bot: I haz the power
Committed patchset #8 (id:140001)
4 years, 5 months ago (2016-07-14 13:41:55 UTC) #32
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 13:44:42 UTC) #34
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/9aa8051f1a8f9b05be0decdb1b09729bc4f5c91e
Cr-Commit-Position: refs/heads/master@{#37766}

Powered by Google App Engine
This is Rietveld 408576698