Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2152703002: Cleanup in SearchTabHelper (Closed)

Created:
4 years, 5 months ago by Marc Treib
Modified:
4 years, 5 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup in SearchTabHelper - Remove unused InitForPreloadedNTP - Make InstantSupportChanged private BUG=627747 Committed: https://crrev.com/d8c5a5e724fbbc898d08b6e87de7484ac332c93e Cr-Commit-Position: refs/heads/master@{#405473}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -37 lines) Patch
M chrome/browser/ui/search/search_tab_helper.h View 3 chunks +5 lines, -10 lines 0 comments Download
M chrome/browser/ui/search/search_tab_helper.cc View 4 chunks +23 lines, -27 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
Marc Treib
PTAL!
4 years, 5 months ago (2016-07-14 10:29:27 UTC) #3
Bernhard Bauer
lgtm
4 years, 5 months ago (2016-07-14 10:35:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2152703002/1
4 years, 5 months ago (2016-07-14 11:07:10 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/103949)
4 years, 5 months ago (2016-07-14 11:37:35 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2152703002/1
4 years, 5 months ago (2016-07-14 11:40:00 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 12:03:06 UTC) #13
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-14 12:03:08 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 12:05:31 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d8c5a5e724fbbc898d08b6e87de7484ac332c93e
Cr-Commit-Position: refs/heads/master@{#405473}

Powered by Google App Engine
This is Rietveld 408576698