Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3182)

Unified Diff: chrome/browser/ui/search/search_tab_helper.h

Issue 2152703002: Cleanup in SearchTabHelper (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/search/search_tab_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/search/search_tab_helper.h
diff --git a/chrome/browser/ui/search/search_tab_helper.h b/chrome/browser/ui/search/search_tab_helper.h
index bc1188ef518c4c8a52f03cdcbe6090470743737b..164bd76a15b4fa215ff440ee9f51cbcbe57a0c61 100644
--- a/chrome/browser/ui/search/search_tab_helper.h
+++ b/chrome/browser/ui/search/search_tab_helper.h
@@ -52,9 +52,6 @@ class SearchTabHelper : public content::WebContentsObserver,
return &model_;
}
- // Sets up the initial state correctly for a preloaded NTP.
- void InitForPreloadedNTP();
-
// Invoked when the omnibox input state is changed in some way that might
// affect the search mode.
void OmniboxInputStateChanged();
@@ -70,9 +67,6 @@ class SearchTabHelper : public content::WebContentsObserver,
// the notification system and shouldn't call this method.
void NavigationEntryUpdated();
- // Invoked to update the instant support state.
- void InstantSupportChanged(bool supports_instant);
-
// Returns true if the page supports instant. If the instant support state is
// not determined or if the page does not support instant returns false.
bool SupportsInstant() const;
@@ -177,12 +171,13 @@ class SearchTabHelper : public content::WebContentsObserver,
void MostVisitedItemsChanged(
const std::vector<InstantMostVisitedItem>& items) override;
+ // Invoked to update the instant support state.
+ void InstantSupportChanged(bool supports_instant);
+
// Sets the mode of the model based on the current URL of web_contents().
// Only updates the origin part of the mode if |update_origin| is true,
- // otherwise keeps the current origin. If |is_preloaded_ntp| is true, the mode
- // is set to NTP regardless of the current URL; this is used to ensure that
- // InstantController can bind InstantTab to new tab pages immediately.
- void UpdateMode(bool update_origin, bool is_preloaded_ntp);
+ // otherwise keeps the current origin.
+ void UpdateMode(bool update_origin);
// Tells the renderer to determine if the page supports the Instant API, which
// results in a call to OnInstantSupportDetermined() when the reply is
« no previous file with comments | « no previous file | chrome/browser/ui/search/search_tab_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698