[stubs] Introduce NonPrimitiveToPrimitive builtin.

[stubs] Introduce NonPrimitiveToPrimitive builtin.

This adds initial support for ToPrimitive in JavaScript w/o having to
call out to C++. This uses the newly introduced GetPropertyStub.

R=ishell@chromium.org

Committed: https://crrev.com/88531cc757b687a8fc69ed2105c3268035500a4f
Cr-Commit-Position: refs/heads/master@{#37753}

[Benedikt Meurer, 2016-07-14 08:23:09]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 08:23:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Benedikt Meurer, 2016-07-14 08:29:28]

Hey Igor,

Here's the first user for GetPropertyStub. :-)
Please take a look.

Thanks,
Benedikt

[commit-bot: I haz the power, 2016-07-14 08:48:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 08:48:42]

Dry run: This issue passed the CQ dry run.

[Igor Sheludko, 2016-07-14 09:41:26]

lgtm with a nit:

https://codereview.chromium.org/2152693002/diff/1/src/builtins/builtins.cc
File src/builtins/builtins.cc (right):

https://codereview.chromium.org/2152693002/diff/1/src/builtins/builtins.cc#ne...
src/builtins/builtins.cc:6229: Node* result_instance_type =
assembler->LoadInstanceType(result);
STATIC_ASSERT(FIRST_PRIMITIVE_TYPE == FIRST_TYPE); to mark the dependency.

[Igor Sheludko, 2016-07-14 09:53:47]

another nit:

https://codereview.chromium.org/2152693002/diff/1/src/builtins/builtins.cc
File src/builtins/builtins.cc (right):

https://codereview.chromium.org/2152693002/diff/1/src/builtins/builtins.cc#ne...
src/builtins/builtins.cc:6166: Node* result_instance_type =
assembler->LoadInstanceType(result);
Same here: STATIC_ASSERT(FIRST_PRIMITIVE_TYPE == FIRST_TYPE);
How about adding IsPrimitive(object)?

[Benedikt Meurer, 2016-07-14 09:56:10]

https://codereview.chromium.org/2152693002/diff/1/src/builtins/builtins.cc
File src/builtins/builtins.cc (right):

https://codereview.chromium.org/2152693002/diff/1/src/builtins/builtins.cc#ne...
src/builtins/builtins.cc:6166: Node* result_instance_type =
assembler->LoadInstanceType(result);
On 2016/07/14 09:53:47, Igor Sheludko wrote:
> Same here: STATIC_ASSERT(FIRST_PRIMITIVE_TYPE == FIRST_TYPE);
> How about adding IsPrimitive(object)?

Hm, that would have to materialize a bit because of the Smi check. So not too
excited about that.

https://codereview.chromium.org/2152693002/diff/1/src/builtins/builtins.cc#ne...
src/builtins/builtins.cc:6229: Node* result_instance_type =
assembler->LoadInstanceType(result);
On 2016/07/14 09:41:25, Igor Sheludko wrote:
> STATIC_ASSERT(FIRST_PRIMITIVE_TYPE == FIRST_TYPE); to mark the dependency.

Done.

[Benedikt Meurer, 2016-07-14 09:56:56]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2016-07-14 09:56:56]

The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org
Link to the patchset: https://codereview.chromium.org/2152693002/#ps20001
(title: "Address comments.")

[commit-bot: I haz the power, 2016-07-14 09:57:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Igor Sheludko, 2016-07-14 10:02:12]

The CQ bit was unchecked by ishell@chromium.org

[Igor Sheludko, 2016-07-14 10:04:17]

Stopped committing because MultiplyStub::Generate() changes in patch set 2 do
not belong to this CL.

[Benedikt Meurer, 2016-07-14 10:23:20]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2016-07-14 10:23:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 10:25:52]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-14 10:27:01]

Description was changed from

==========
[stubs] Introduce NonPrimitiveToPrimitive builtin.

This adds initial support for ToPrimitive in JavaScript w/o having to
call out to C++. This uses the newly introduced GetPropertyStub.

R=ishell@chromium.org
==========

to

==========
[stubs] Introduce NonPrimitiveToPrimitive builtin.

This adds initial support for ToPrimitive in JavaScript w/o having to
call out to C++. This uses the newly introduced GetPropertyStub.

R=ishell@chromium.org

Committed: https://crrev.com/88531cc757b687a8fc69ed2105c3268035500a4f
Cr-Commit-Position: refs/heads/master@{#37753}
==========

[commit-bot: I haz the power, 2016-07-14 10:27:03]

Patchset 2 (id:??) landed as
https://crrev.com/88531cc757b687a8fc69ed2105c3268035500a4f
Cr-Commit-Position: refs/heads/master@{#37753}