[stubs] Introduce NonPrimitiveToPrimitive builtin.

src/code-stubs.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/code-stubs.h"
 
 #include <sstream>
 
 #include "src/bootstrapper.h"
 #include "src/code-factory.h"
@@ skipping 601 matching lines @@
                 if_rhsisnotreceiver(assembler, Label::kDeferred);
             assembler->Branch(
                 assembler->Int32LessThanOrEqual(
                     assembler->Int32Constant(FIRST_JS_RECEIVER_TYPE),
                     rhs_instance_type),
                 &if_rhsisreceiver, &if_rhsisnotreceiver);
 
             assembler->Bind(&if_rhsisreceiver);
             {
               // Convert {rhs} to a primitive first passing no hint.
-              // TODO(bmeurer): Hook up ToPrimitiveStub here, once it's there.
-              var_rhs.Bind(
-                  assembler->CallRuntime(Runtime::kToPrimitive, context, rhs));
+              Callable callable =
+                  CodeFactory::NonPrimitiveToPrimitive(assembler->isolate());
+              var_rhs.Bind(assembler->CallStub(callable, context, rhs));
               assembler->Goto(&loop);
             }
 
             assembler->Bind(&if_rhsisnotreceiver);
             {
               // Convert {rhs} to a Number first.
               Callable callable =
                   CodeFactory::NonNumberToNumber(assembler->isolate());
               var_rhs.Bind(assembler->CallStub(callable, context, rhs));
               assembler->Goto(&loop);
@@ skipping 55 matching lines @@
                 if_lhsisnotreceiver(assembler, Label::kDeferred);
             assembler->Branch(
                 assembler->Int32LessThanOrEqual(
                     assembler->Int32Constant(FIRST_JS_RECEIVER_TYPE),
                     lhs_instance_type),
                 &if_lhsisreceiver, &if_lhsisnotreceiver);
 
             assembler->Bind(&if_lhsisreceiver);
             {
               // Convert {lhs} to a primitive first passing no hint.
-              // TODO(bmeurer): Hook up ToPrimitiveStub here, once it's there.
-              var_lhs.Bind(
-                  assembler->CallRuntime(Runtime::kToPrimitive, context, lhs));
+              Callable callable =
+                  CodeFactory::NonPrimitiveToPrimitive(assembler->isolate());
+              var_lhs.Bind(assembler->CallStub(callable, context, lhs));
               assembler->Goto(&loop);
             }
 
             assembler->Bind(&if_lhsisnotreceiver);
             {
               // Convert {lhs} to a Number first.
               Callable callable =
                   CodeFactory::NonNumberToNumber(assembler->isolate());
               var_lhs.Bind(assembler->CallStub(callable, context, lhs));
               assembler->Goto(&loop);
@@ skipping 54 matching lines @@
                     if_rhsisnotreceiver(assembler, Label::kDeferred);
                 assembler->Branch(
                     assembler->Int32LessThanOrEqual(
                         assembler->Int32Constant(FIRST_JS_RECEIVER_TYPE),
                         rhs_instance_type),
                     &if_rhsisreceiver, &if_rhsisnotreceiver);
 
                 assembler->Bind(&if_rhsisreceiver);
                 {
                   // Convert {rhs} to a primitive first passing no hint.
-                  // TODO(bmeurer): Hook up ToPrimitiveStub here too.
-                  var_rhs.Bind(assembler->CallRuntime(Runtime::kToPrimitive,
-                                                      context, rhs));
+                  Callable callable = CodeFactory::NonPrimitiveToPrimitive(
+                      assembler->isolate());
+                  var_rhs.Bind(assembler->CallStub(callable, context, rhs));
                   assembler->Goto(&loop);
                 }
 
                 assembler->Bind(&if_rhsisnotreceiver);
                 {
                   // Convert {rhs} to a Number first.
                   Callable callable =
                       CodeFactory::NonNumberToNumber(assembler->isolate());
                   var_rhs.Bind(assembler->CallStub(callable, context, rhs));
                   assembler->Goto(&loop);
                 }
               }
             }
 
             assembler->Bind(&if_lhsisnotnumber);
             {
               // Check if {lhs} is a JSReceiver.
               Label if_lhsisreceiver(assembler, Label::kDeferred),
                   if_lhsisnotreceiver(assembler);
               assembler->Branch(
                   assembler->Int32LessThanOrEqual(
                       assembler->Int32Constant(FIRST_JS_RECEIVER_TYPE),
                       lhs_instance_type),
                   &if_lhsisreceiver, &if_lhsisnotreceiver);
 
               assembler->Bind(&if_lhsisreceiver);
               {
                 // Convert {lhs} to a primitive first passing no hint.
-                // TODO(bmeurer): Hook up ToPrimitiveStub here, once it's there.
-                var_lhs.Bind(assembler->CallRuntime(Runtime::kToPrimitive,
-                                                    context, lhs));
+                Callable callable =
+                    CodeFactory::NonPrimitiveToPrimitive(assembler->isolate());
+                var_lhs.Bind(assembler->CallStub(callable, context, lhs));
                 assembler->Goto(&loop);
               }
 
               assembler->Bind(&if_lhsisnotreceiver);
               {
                 // Check if {rhs} is a JSReceiver.
                 Label if_rhsisreceiver(assembler, Label::kDeferred),
                     if_rhsisnotreceiver(assembler, Label::kDeferred);
                 assembler->Branch(
                     assembler->Int32LessThanOrEqual(
                         assembler->Int32Constant(FIRST_JS_RECEIVER_TYPE),
                         rhs_instance_type),
                     &if_rhsisreceiver, &if_rhsisnotreceiver);
 
                 assembler->Bind(&if_rhsisreceiver);
                 {
                   // Convert {rhs} to a primitive first passing no hint.
-                  // TODO(bmeurer): Hook up ToPrimitiveStub here too.
-                  var_rhs.Bind(assembler->CallRuntime(Runtime::kToPrimitive,
-                                                      context, rhs));
+                  Callable callable = CodeFactory::NonPrimitiveToPrimitive(
+                      assembler->isolate());
+                  var_rhs.Bind(assembler->CallStub(callable, context, rhs));
                   assembler->Goto(&loop);
                 }
 
                 assembler->Bind(&if_rhsisnotreceiver);
                 {
                   // Convert {lhs} to a Number first.
                   Callable callable =
                       CodeFactory::NonNumberToNumber(assembler->isolate());
                   var_lhs.Bind(assembler->CallStub(callable, context, lhs));
                   assembler->Goto(&loop);
@@ skipping 1363 matching lines @@
                   if_rhsisnotreceiver(assembler, Label::kDeferred);
               assembler->Branch(
                   assembler->Int32LessThanOrEqual(
                       assembler->Int32Constant(FIRST_JS_RECEIVER_TYPE),
                       rhs_instance_type),
                   &if_rhsisreceiver, &if_rhsisnotreceiver);
 
               assembler->Bind(&if_rhsisreceiver);
               {
                 // Convert {rhs} to a primitive first passing Number hint.
-                // TODO(bmeurer): Hook up ToPrimitiveStub here, once it's there.
-                var_rhs.Bind(assembler->CallRuntime(
-                    Runtime::kToPrimitive_Number, context, rhs));
+                Callable callable = CodeFactory::NonPrimitiveToPrimitive(
+                    assembler->isolate(), ToPrimitiveHint::kNumber);
+                var_rhs.Bind(assembler->CallStub(callable, context, rhs));
                 assembler->Goto(&loop);
               }
 
               assembler->Bind(&if_rhsisnotreceiver);
               {
                 // Convert both {lhs} and {rhs} to Number.
                 Callable callable = CodeFactory::ToNumber(assembler->isolate());
                 var_lhs.Bind(assembler->CallStub(callable, context, lhs));
                 var_rhs.Bind(assembler->CallStub(callable, context, rhs));
                 assembler->Goto(&loop);
@@ skipping 11 matching lines @@
                 if_lhsisnotreceiver(assembler, Label::kDeferred);
             assembler->Branch(
                 assembler->Int32LessThanOrEqual(
                     assembler->Int32Constant(FIRST_JS_RECEIVER_TYPE),
                     lhs_instance_type),
                 &if_lhsisreceiver, &if_lhsisnotreceiver);
 
             assembler->Bind(&if_lhsisreceiver);
             {
               // Convert {lhs} to a primitive first passing Number hint.
-              // TODO(bmeurer): Hook up ToPrimitiveStub here, once it's there.
-              var_lhs.Bind(assembler->CallRuntime(Runtime::kToPrimitive_Number,
-                                                  context, lhs));
+              Callable callable = CodeFactory::NonPrimitiveToPrimitive(
+                  assembler->isolate(), ToPrimitiveHint::kNumber);
+              var_lhs.Bind(assembler->CallStub(callable, context, lhs));
               assembler->Goto(&loop);
             }
 
             assembler->Bind(&if_lhsisnotreceiver);
             {
               // Convert both {lhs} and {rhs} to Number.
               Callable callable = CodeFactory::ToNumber(assembler->isolate());
               var_lhs.Bind(assembler->CallStub(callable, context, lhs));
               var_rhs.Bind(assembler->CallStub(callable, context, rhs));
               assembler->Goto(&loop);
@@ skipping 303 matching lines @@
                     if_rhsisnotreceiver(assembler);
                 assembler->Branch(
                     assembler->Int32LessThanOrEqual(
                         assembler->Int32Constant(FIRST_JS_RECEIVER_TYPE),
                         rhs_instance_type),
                     &if_rhsisreceiver, &if_rhsisnotreceiver);
 
                 assembler->Bind(&if_rhsisreceiver);
                 {
                   // Convert {rhs} to a primitive first (passing no hint).
-                  // TODO(bmeurer): Hook up ToPrimitiveStub here once it exists.
-                  var_rhs.Bind(assembler->CallRuntime(Runtime::kToPrimitive,
-                                                      context, rhs));
+                  Callable callable = CodeFactory::NonPrimitiveToPrimitive(
+                      assembler->isolate());
+                  var_rhs.Bind(assembler->CallStub(callable, context, rhs));
                   assembler->Goto(&loop);
                 }
 
                 assembler->Bind(&if_rhsisnotreceiver);
                 assembler->Goto(&if_notequal);
               }
             }
           }
         }
       }
@@ skipping 335 matching lines @@
                     assembler->Word32And(
                         lhs_bitfield,
                         assembler->Int32Constant(1 << Map::kIsUndetectable)),
                     assembler->Int32Constant(0), &if_notequal, &if_equal);
               }
 
               assembler->Bind(&if_rhsisnotundetectable);
               {
                 // The {rhs} is some Primitive different from Null and
                 // Undefined, need to convert {lhs} to Primitive first.
-                // TODO(bmeurer): Hook up ToPrimitiveStub here once it exists.
-                var_lhs.Bind(assembler->CallRuntime(Runtime::kToPrimitive,
-                                                    context, lhs));
+                Callable callable =
+                    CodeFactory::NonPrimitiveToPrimitive(assembler->isolate());
+                var_lhs.Bind(assembler->CallStub(callable, context, lhs));
                 assembler->Goto(&loop);
               }
             }
           }
         }
       }
     }
 
     assembler->Bind(&do_rhsstringtonumber);
     {
@@ skipping 2035 matching lines @@
   if (type->Is(Type::UntaggedPointer())) {
     return Representation::External();
   }
 
   DCHECK(!type->Is(Type::Untagged()));
   return Representation::Tagged();
 }
 
 }  // namespace internal
 }  // namespace v8