content/browser/tracing/tracing_controller_impl.h - Issue 2152603002: Tracing: do not pass entire trace content in TraceDataEndpoint::ReceiveTraceFinalContents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/tracing/tracing_controller_impl.h

Issue 2152603002: Tracing: do not pass entire trace content in TraceDataEndpoint::ReceiveTraceFinalContents (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments addressed Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/tracing/tracing_controller_browsertest.cc ('k') | content/browser/tracing/tracing_controller_impl_data_sinks.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/tracing/tracing_controller_impl.h

diff --git a/content/browser/tracing/tracing_controller_impl.h b/content/browser/tracing/tracing_controller_impl.h

index 326ec43a2eb4c6f0a511511f23e37061b41d46e9..7d769e97794361b943f0f9ab099dc473df647f07 100644

--- a/content/browser/tracing/tracing_controller_impl.h

+++ b/content/browser/tracing/tracing_controller_impl.h

@@ -39,8 +39,7 @@ class CONTENT_EXPORT TraceDataEndpoint

public:

virtual void ReceiveTraceChunk(const std::string& chunk) {}

virtual void ReceiveTraceFinalContents(

- std::unique_ptr<const base::DictionaryValue> metadata,

- const std::string& contents) {}

+ std::unique_ptr<const base::DictionaryValue> metadata) {}

protected:

friend class base::RefCountedThreadSafe<TraceDataEndpoint>;