Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Unified Diff: content/browser/tracing/tracing_controller_browsertest.cc

Issue 2152603002: Tracing: do not pass entire trace content in TraceDataEndpoint::ReceiveTraceFinalContents (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments addressed Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/tracing/tracing_controller_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/tracing/tracing_controller_browsertest.cc
diff --git a/content/browser/tracing/tracing_controller_browsertest.cc b/content/browser/tracing/tracing_controller_browsertest.cc
index 52401ee06d7f759ff72f925fd23b614730e7a086..47d60b595b1fd241d6f833df3370debdb6e2b3b7 100644
--- a/content/browser/tracing/tracing_controller_browsertest.cc
+++ b/content/browser/tracing/tracing_controller_browsertest.cc
@@ -71,13 +71,9 @@ class TracingControllerTestEndpoint : public TraceDataEndpoint {
}
void ReceiveTraceFinalContents(
- std::unique_ptr<const base::DictionaryValue> metadata,
- const std::string& contents) override {
- EXPECT_EQ(trace_, contents);
-
- std::string tmp = contents;
+ std::unique_ptr<const base::DictionaryValue> metadata) override {
scoped_refptr<base::RefCountedString> chunk_ptr =
- base::RefCountedString::TakeString(&tmp);
+ base::RefCountedString::TakeString(&trace_);
BrowserThread::PostTask(
BrowserThread::UI, FROM_HERE,
« no previous file with comments | « no previous file | content/browser/tracing/tracing_controller_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698