Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2152573002: Fix ASAN bot (Closed)

Created:
4 years, 5 months ago by msarett
Modified:
4 years, 5 months ago
Reviewers:
caryclark, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tests/GeometryTest.cpp View 1 chunk +1 line, -1 line 1 comment Download

Depends on Patchset:

Issue 2059283002 Patch 40001

Messages

Total messages: 14 (9 generated)
msarett
4 years, 5 months ago (2016-07-13 19:45:52 UTC) #5
caryclark
lgtm
4 years, 5 months ago (2016-07-13 19:53:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2152573002/1
4 years, 5 months ago (2016-07-13 20:07:50 UTC) #11
reed1
https://codereview.chromium.org/2152573002/diff/1/tests/GeometryTest.cpp File tests/GeometryTest.cpp (right): https://codereview.chromium.org/2152573002/diff/1/tests/GeometryTest.cpp#newcode166 tests/GeometryTest.cpp:166: { 0, 0 }, { 3.58732e-43f, 2.72084f }, { ...
4 years, 5 months ago (2016-07-13 20:08:27 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 20:08:47 UTC) #14
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/16ef465ea92291b860ee5ea8f3d51d5d3f4f1059

Powered by Google App Engine
This is Rietveld 408576698