scripts/slave/recipes/chromium.expected/full_chromium_win_Win8_GYP__dbg_.json - Issue 2152453003: recipes: Stop passing --build-tool=ninja to compile.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/chromium.expected/full_chromium_win_Win8_GYP__dbg_.json

Issue 2152453003: recipes: Stop passing --build-tool=ninja to compile.py (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/chromium.expected/full_chromium_win_Win8_GYP.json ('k') | scripts/slave/recipes/chromium.expected/full_chromium_win_WinClang64__dbg_.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/chromium.expected/full_chromium_win_Win8_GYP__dbg_.json

diff --git a/scripts/slave/recipes/chromium.expected/full_chromium_win_Win8_GYP__dbg_.json b/scripts/slave/recipes/chromium.expected/full_chromium_win_Win8_GYP__dbg_.json

index e26678e84335ed8d14fd3b18621ddc1a36cfe21f..49ca7faf7b929f892f3cdf9f759cb2fbb773bcf9 100644

--- a/scripts/slave/recipes/chromium.expected/full_chromium_win_Win8_GYP__dbg_.json

+++ b/scripts/slave/recipes/chromium.expected/full_chromium_win_Win8_GYP__dbg_.json

@@ -335,8 +335,6 @@

"[GOMA_CACHE]",

"--goma-deps-cache-dir",

"[GOMA_DEPS_CACHE]",

- "--build-tool",

- "ninja",

"--build-data-dir",

"[ROOT]\\build_data_dir",

"--compiler",