scripts/slave/recipes/chromium.expected/full_chromium_win_Win8_GYP__dbg_.json - Issue 2152453003: recipes: Stop passing --build-tool=ninja to compile.py

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: scripts/slave/recipes/chromium.expected/full_chromium_win_Win8_GYP__dbg_.json

Issue 2152453003: recipes: Stop passing --build-tool=ninja to compile.py (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « scripts/slave/recipes/chromium.expected/full_chromium_win_Win8_GYP.json ('k') | scripts/slave/recipes/chromium.expected/full_chromium_win_WinClang64__dbg_.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 [	1 [

2 {	2 {

3 "cmd": [	3 "cmd": [

4 "python",	4 "python",

5 "-u",	5 "-u",

6 "RECIPE_PACKAGE_REPO[build]\\scripts\\slave\\kill_processes.py"	6 "RECIPE_PACKAGE_REPO[build]\\scripts\\slave\\kill_processes.py"

7 ],	7 ],

8 "name": "taskkill"	8 "name": "taskkill"

9 },	9 },

10 {	10 {

(...skipping 317 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
328 "--ninja-path",	328 "--ninja-path",

329 "RECIPE_PACKAGE_REPO[depot_tools]\\ninja.exe",	329 "RECIPE_PACKAGE_REPO[depot_tools]\\ninja.exe",

330 "--target",	330 "--target",

331 "Debug",	331 "Debug",

332 "--src-dir",	332 "--src-dir",

333 "[BUILDER_CACHE]\\Win8_GYP__dbg_\\src",	333 "[BUILDER_CACHE]\\Win8_GYP__dbg_\\src",

334 "--goma-cache-dir",	334 "--goma-cache-dir",

335 "[GOMA_CACHE]",	335 "[GOMA_CACHE]",

336 "--goma-deps-cache-dir",	336 "--goma-deps-cache-dir",

337 "[GOMA_DEPS_CACHE]",	337 "[GOMA_DEPS_CACHE]",

338 "--build-tool",

339 "ninja",

340 "--build-data-dir",	338 "--build-data-dir",

341 "[ROOT]\\build_data_dir",	339 "[ROOT]\\build_data_dir",

342 "--compiler",	340 "--compiler",

343 "goma",	341 "goma",

344 "--goma-jsonstatus",	342 "--goma-jsonstatus",

345 "/path/to/tmp/json",	343 "/path/to/tmp/json",

346 "--goma-service-account-json-file",	344 "--goma-service-account-json-file",

347 "C:\\creds\\service_accounts\\service-account-goma-client.json",	345 "C:\\creds\\service_accounts\\service-account-goma-client.json",

348 "--goma-dir",	346 "--goma-dir",

349 "[CACHE]\\cipd\\goma",	347 "[CACHE]\\cipd\\goma",

(...skipping 122 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
472 "GOMA_SERVICE_ACCOUNT_JSON_FILE": "C:\\creds\\service_accounts\\service-ac count-goma-client.json"	470 "GOMA_SERVICE_ACCOUNT_JSON_FILE": "C:\\creds\\service_accounts\\service-ac count-goma-client.json"

473 },	471 },

474 "name": "process_dumps"	472 "name": "process_dumps"

475 },	473 },

476 {	474 {

477 "name": "$result",	475 "name": "$result",

478 "recipe_result": null,	476 "recipe_result": null,

479 "status_code": 0	477 "status_code": 0

480 }	478 }

481 ]	479 ]

OLD	NEW