tools/gn/json_project_writer.h - Issue 2152413002: GN: don't write separate files for non-binary targets

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/json_project_writer.h

Issue 2152413002: GN: don't write separate files for non-binary targets (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: typo Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gn/json_project_writer.h

diff --git a/tools/gn/json_project_writer.h b/tools/gn/json_project_writer.h

index e69dc3ac94fdc564ee508ee3243f16d4b359b027..8c293bfd93d9cb5a58f2947f89f50a77e0ee46f1 100644

--- a/tools/gn/json_project_writer.h

+++ b/tools/gn/json_project_writer.h

@@ -14,7 +14,7 @@ class BuildSettings;

class JSONProjectWriter {

public:

static bool RunAndWriteFiles(const BuildSettings* build_setting,

- const Builder* builder,

+ const Builder& builder,

const std::string& file_name,

const std::string& exec_script,

const std::string& exec_script_extra_args,

« no previous file with comments | « tools/gn/eclipse_writer.cc ('k') | tools/gn/json_project_writer.cc » ('j') | no next file with comments »