Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: tools/gn/json_project_writer.cc

Issue 2152413002: GN: don't write separate files for non-binary targets (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: typo Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/json_project_writer.h ('k') | tools/gn/ninja_build_writer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/json_project_writer.cc
diff --git a/tools/gn/json_project_writer.cc b/tools/gn/json_project_writer.cc
index 272a2887064078164c60231d7a0574ef59ff1592..dc375a64d940d6c26fc8af074cfe59a8ccad4139 100644
--- a/tools/gn/json_project_writer.cc
+++ b/tools/gn/json_project_writer.cc
@@ -82,7 +82,7 @@ bool FilterTargets(const BuildSettings* build_settings,
}
std::string RenderJSON(const BuildSettings* build_settings,
- const Builder* builder,
+ const Builder& builder,
std::vector<const Target*>& all_targets) {
Label default_toolchain_label;
@@ -167,7 +167,7 @@ bool InvokePython(const BuildSettings* build_settings,
bool JSONProjectWriter::RunAndWriteFiles(
const BuildSettings* build_settings,
- const Builder* builder,
+ const Builder& builder,
const std::string& file_name,
const std::string& exec_script,
const std::string& exec_script_extra_args,
@@ -182,7 +182,7 @@ bool JSONProjectWriter::RunAndWriteFiles(
base::FilePath output_path = build_settings->GetFullPath(output_file);
- std::vector<const Target*> all_targets = builder->GetAllResolvedTargets();
+ std::vector<const Target*> all_targets = builder.GetAllResolvedTargets();
std::vector<const Target*> targets;
if (!FilterTargets(build_settings, all_targets, &targets, dir_filter_string,
err)) {
« no previous file with comments | « tools/gn/json_project_writer.h ('k') | tools/gn/ninja_build_writer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698