Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Unified Diff: tools/gn/eclipse_writer.h

Issue 2152413002: GN: don't write separate files for non-binary targets (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: typo Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/commands.cc ('k') | tools/gn/eclipse_writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/eclipse_writer.h
diff --git a/tools/gn/eclipse_writer.h b/tools/gn/eclipse_writer.h
index 560b8729e02fc177aa265ef3639c0603207359fd..e15254fbadbbb36e1e0e177eb8904aa82cc68edf 100644
--- a/tools/gn/eclipse_writer.h
+++ b/tools/gn/eclipse_writer.h
@@ -21,12 +21,12 @@ class Target;
class EclipseWriter {
public:
static bool RunAndWriteFile(const BuildSettings* build_settings,
- const Builder* builder,
+ const Builder& builder,
Err* err);
private:
EclipseWriter(const BuildSettings* build_settings,
- const Builder* builder,
+ const Builder& builder,
std::ostream& out);
~EclipseWriter();
@@ -47,7 +47,7 @@ class EclipseWriter {
void WriteCDTSettings();
const BuildSettings* build_settings_;
- const Builder* builder_;
+ const Builder& builder_;
// The output stream for the settings file.
std::ostream& out_;
« no previous file with comments | « tools/gn/commands.cc ('k') | tools/gn/eclipse_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698