Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: tools/gn/commands.cc

Issue 2152413002: GN: don't write separate files for non-binary targets (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: typo Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/command_refs.cc ('k') | tools/gn/eclipse_writer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/commands.cc
diff --git a/tools/gn/commands.cc b/tools/gn/commands.cc
index 492b74f12a0afaf37de68c57c2dcbca831b0fe30..bf89c959b373b4160b75465b15d955418d4dd291 100644
--- a/tools/gn/commands.cc
+++ b/tools/gn/commands.cc
@@ -56,7 +56,7 @@ bool ResolveTargetsFromCommandLinePattern(
std::vector<LabelPattern> pattern_vector;
pattern_vector.push_back(pattern);
- FilterTargetsByPatterns(setup->builder()->GetAllResolvedTargets(),
+ FilterTargetsByPatterns(setup->builder().GetAllResolvedTargets(),
pattern_vector, matches);
return true;
}
@@ -102,7 +102,7 @@ bool ResolveStringFromCommandLineInput(
return true;
}
- const Item* item = setup->builder()->GetItem(label);
+ const Item* item = setup->builder().GetItem(label);
if (item) {
if (const Config* as_config = item->AsConfig())
config_matches->push_back(as_config);
@@ -391,7 +391,7 @@ const Target* ResolveTargetFromCommandLineString(
return nullptr;
}
- const Item* item = setup->builder()->GetItem(label);
+ const Item* item = setup->builder().GetItem(label);
if (!item) {
Err(Location(), "Label not found.",
label.GetUserVisibleName(false) + " not found.").PrintToStdout();
« no previous file with comments | « tools/gn/command_refs.cc ('k') | tools/gn/eclipse_writer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698