Add support for Fuchsia

Add support for Fuchsia
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2152273002

[mtklein edit from here down]
No public API changes.
TBR=reed@google.com

Committed: https://skia.googlesource.com/skia/+/6fc8ff024bd823f350400a86e7b9daa1c25f618e

[abarth-chromium, 2016-07-15 16:37:11]

Description was changed from

==========
Add support for Fuchsia
==========

to

==========
Add support for Fuchsia
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2152273002
==========

[reed1, 2016-07-15 16:47:38]

reed@google.com changed reviewers:
+ bungeman@google.com, mtklein@google.com, reed@google.com

[mtklein, 2016-07-15 16:49:58]

You're using our BUILD.gn?  Neat/scary.  That was like, step 1 of 1000...

[abarth, 2016-07-15 16:51:05]

On 2016/07/15 at 16:49:58, mtklein wrote:
> You're using our BUILD.gn?  Neat/scary.  That was like, step 1 of 1000...

I can make my own BUILD.gn for you if you'd prefer, but it seemed cleaner to use
yours.

[mtklein, 2016-07-15 16:54:03]

https://codereview.chromium.org/2152273002/diff/20001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2152273002/diff/20001/BUILD.gn#newcode75
BUILD.gn:75: if (!is_fuchsia) {
Is this... you sync Skia under a Fuschia GN root, which doesn't have
//build/config/clang:find_bad_constructs or //build/config:feature_flags to
start with?

https://codereview.chromium.org/2152273002/diff/20001/BUILD.gn#newcode173
BUILD.gn:173: deps += [ "//third_party/zlib" ]
Think we should just create third_party/zlib/BUILD.gn so we can unconditionally
include //third_party/zlib?

[mtklein, 2016-07-15 16:54:25]

On 2016/07/15 16:51:05, abarth wrote:
> On 2016/07/15 at 16:49:58, mtklein wrote:
> > You're using our BUILD.gn?  Neat/scary.  That was like, step 1 of 1000...
> 
> I can make my own BUILD.gn for you if you'd prefer, but it seemed cleaner to
use
> yours.

Nope, this seems like a good idea.  It's just scary the first time it starts to
matter.

[abarth, 2016-07-15 17:48:54]

abarth@google.com changed reviewers:
+ abarth@google.com

[abarth, 2016-07-15 17:48:54]

https://codereview.chromium.org/2152273002/diff/20001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2152273002/diff/20001/BUILD.gn#newcode75
BUILD.gn:75: if (!is_fuchsia) {
On 2016/07/15 at 16:54:03, mtklein wrote:
> Is this... you sync Skia under a Fuschia GN root, which doesn't have
//build/config/clang:find_bad_constructs or //build/config:feature_flags to
start with?

That's correct.  Our gn environment is less opinionated than Chromium's
environment.

https://codereview.chromium.org/2152273002/diff/20001/BUILD.gn#newcode173
BUILD.gn:173: deps += [ "//third_party/zlib" ]
On 2016/07/15 at 16:54:03, mtklein wrote:
> Think we should just create third_party/zlib/BUILD.gn so we can
unconditionally include //third_party/zlib?

Yes, that would make more sense.  Do you want me to do that in this patch or do
you want to do that as a follow up?

[mtklein, 2016-07-15 17:51:47]

On 2016/07/15 17:48:54, abarth wrote:
> https://codereview.chromium.org/2152273002/diff/20001/BUILD.gn
> File BUILD.gn (right):
> 
> https://codereview.chromium.org/2152273002/diff/20001/BUILD.gn#newcode75
> BUILD.gn:75: if (!is_fuchsia) {
> On 2016/07/15 at 16:54:03, mtklein wrote:
> > Is this... you sync Skia under a Fuschia GN root, which doesn't have
> //build/config/clang:find_bad_constructs or //build/config:feature_flags to
> start with?
> 
> That's correct.  Our gn environment is less opinionated than Chromium's
> environment.
> 
> https://codereview.chromium.org/2152273002/diff/20001/BUILD.gn#newcode173
> BUILD.gn:173: deps += [ "//third_party/zlib" ]
> On 2016/07/15 at 16:54:03, mtklein wrote:
> > Think we should just create third_party/zlib/BUILD.gn so we can
> unconditionally include //third_party/zlib?
> 
> Yes, that would make more sense.  Do you want me to do that in this patch or
do
> you want to do that as a follow up?

Let's do it here!

[abarth, 2016-07-15 18:37:03]

Updated.  PTAL.

[mtklein, 2016-07-15 19:19:38]

lgtm

[abarth, 2016-07-15 19:51:54]

The CQ bit was checked by abarth@google.com

[commit-bot: I haz the power, 2016-07-15 19:52:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 19:53:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 19:53:31]

Try jobs failed on following builders:
  skia_presubmit-Trybot on master.client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[abarth, 2016-07-15 19:54:57]

Looks like I need more LGTM sauce for the change to include/core/SkPreConfig.h

[mtklein, 2016-07-15 19:58:51]

Description was changed from

==========
Add support for Fuchsia
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2152273002
==========

to

==========
Add support for Fuchsia
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2152273002

[mtklein edit from here down]
No public API changes.
TBR=reed@google.com
==========

[mtklein, 2016-07-15 19:58:58]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2016-07-15 19:59:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mtklein, 2016-07-15 19:59:51]

Nah, let's TBR Mike.  There's no public API change here.

You will need to only include unistd.h on platforms that have it, though.

[commit-bot: I haz the power, 2016-07-15 20:05:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 20:05:37]

Try jobs failed on following builders:
  Build-Win-MSVC-x86_64-Debug-Trybot on master.client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

[reed1, 2016-07-15 21:17:21]

agreed that you can TBR me for this sort of api mod

[abarth, 2016-07-15 21:51:26]

The CQ bit was checked by abarth@google.com

[abarth, 2016-07-15 21:51:27]

The patchset sent to the CQ was uploaded after l-g-t-m from abarth@google.com,
mtklein@google.com
Link to the patchset: https://codereview.chromium.org/2152273002/#ps80001
(title: "Fix win build")

[commit-bot: I haz the power, 2016-07-15 21:51:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 22:15:17]

Description was changed from

==========
Add support for Fuchsia
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2152273002

[mtklein edit from here down]
No public API changes.
TBR=reed@google.com
==========

to

==========
Add support for Fuchsia
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2152273002

[mtklein edit from here down]
No public API changes.
TBR=reed@google.com

Committed:
https://skia.googlesource.com/skia/+/6fc8ff024bd823f350400a86e7b9daa1c25f618e
==========

[commit-bot: I haz the power, 2016-07-15 22:15:19]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/6fc8ff024bd823f350400a86e7b9daa1c25f618e

[jcgregorio, 2016-07-18 21:09:45]

On 2016/07/15 at 22:15:19, commit-bot wrote:
> Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/6fc8ff024bd823f350400a86e7b9daa1c25f618e



$ gn gen out/Default
ERROR at //BUILD.gn:75:6: Undefined identifier
if (!is_fuchsia) {
     ^---------
1 (


Am I missing something locally?

[abarth, 2016-07-18 21:36:58]

On 2016/07/18 at 21:09:45, jcgregorio wrote:
> Am I missing something locally?

Looks like brettw rejected my patch: https://codereview.chromium.org/2154493003

The workaround is to write

if (current_os == "fuscia") { ... }

instead.

[abarth, 2016-07-18 21:49:18]

Sorry:

> if (current_os == "fuchsia") { ... }