Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 2154493003: None of these operating systems are fuchsia (Closed)

Created:
4 years, 5 months ago by abarth-chromium
Modified:
4 years, 5 months ago
Reviewers:
abarth, brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

None of these operating systems are fuchsia This CL lets common dependencies between Chromium and Fuchsia build with the same set of BUILD.gn files. For example, Skia can now check is_fuchsia in their BUILD.gn file to configure their build for Fuchsia. This patch will also be useful when if/when we port Chromium to Fuchsia. R=brettw@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M build/config/BUILDCONFIG.gn View 7 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
abarth
4 years, 5 months ago (2016-07-15 17:24:08 UTC) #2
brettw
Given the uncertainty here and the fact that most people don't even know what this ...
4 years, 5 months ago (2016-07-15 20:06:37 UTC) #3
abarth
On 2016/07/15 at 20:06:37, brettw wrote: > For now, if you want build files to ...
4 years, 5 months ago (2016-07-18 21:48:26 UTC) #4
brettw
4 years, 5 months ago (2016-07-20 19:23:23 UTC) #5
On 2016/07/18 21:48:26, abarth wrote:
> On 2016/07/15 at 20:06:37, brettw wrote:
> > For now, if you want build files to check this, they can always check
> >   if (current_os == "fuscia") { ... }
> > We already do this for some variants of WindowsRT, for example (open source
> people have contributed this),
> 
> Ok, we can use that workaround for now.  It's less good than having the gn
> variable because gn provides error checking for variables (e.g., for typos). 
> Certainly in our own BUILDCONFIG.gn we use a variable here for this reason. 
> It's unfortunate that our shared dependencies (e.g., Skia) will have more
> error-prone BUILD.gn files than they would if our projects were more willing
to
> cooperate on these trivial things.
> 
> > WindowsRT seems more real that Fuscia at this point.
> 
> I'm not sure what point you were trying to make with this statement, but it
> seems pretty rude to characterize the work my team is doing as not real.  :(

I am trying to say we've rejected similar use cases that already have more code
landed in the Chrome repo. The intent is not to provide a global build variable
for everything anybody thinks of doing. The string is deliberately design to
allow these more experimental enhancements.

Powered by Google App Engine
This is Rietveld 408576698