Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 2152153002: Fix rpath dependencies in ASAN builds of chrome_sandbox. (Closed)

Created:
4 years, 5 months ago by Dirk Pranke
Modified:
4 years, 5 months ago
CC:
chromium-reviews, jln+watch_chromium.org, rickyz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix rpath dependencies in ASAN builds of chrome_sandbox. chrome_sandbox is a setuid binary, so we don't want it to pick up -Wl,-rpath=$ORIGIN. Binaries built with sanitizers might need that flag in order to pick up the instrumented libraries properly, so the fix for this is to just not build chrome_sandbox with any of the sanitizer flags. R=rickyz@chromium.org, llozano@chromium.org BUG=624901 Committed: https://crrev.com/651705fee413b0e84bddbf65ae563c7c6e7e2868 Cr-Commit-Position: refs/heads/master@{#405692}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M sandbox/linux/BUILD.gn View 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Dirk Pranke
4 years, 5 months ago (2016-07-15 02:16:46 UTC) #1
rickyz (no longer on Chrome)
lgtm, thanks (I see we were already doing this in gyp)!
4 years, 5 months ago (2016-07-15 02:22:43 UTC) #2
Dirk Pranke
On 2016/07/15 02:22:43, rickyz wrote: > lgtm, thanks (I see we were already doing this ...
4 years, 5 months ago (2016-07-15 02:49:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2152153002/1
4 years, 5 months ago (2016-07-15 02:50:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-15 03:59:01 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 04:00:43 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/651705fee413b0e84bddbf65ae563c7c6e7e2868
Cr-Commit-Position: refs/heads/master@{#405692}

Powered by Google App Engine
This is Rietveld 408576698