Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: sandbox/linux/BUILD.gn

Issue 2152153002: Fix rpath dependencies in ASAN builds of chrome_sandbox. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/features.gni") 5 import("//build/config/features.gni")
6 import("//build/config/nacl/config.gni") 6 import("//build/config/nacl/config.gni")
7 import("//testing/test.gni") 7 import("//testing/test.gni")
8 8
9 if (is_android) { 9 if (is_android) {
10 import("//build/config/android/rules.gni") 10 import("//build/config/android/rules.gni")
(...skipping 288 matching lines...) Expand 10 before | Expand all | Expand 10 after
299 # For ULLONG_MAX 299 # For ULLONG_MAX
300 "-std=gnu99", 300 "-std=gnu99",
301 301
302 # These files have a suspicious comparison. 302 # These files have a suspicious comparison.
303 # TODO fix this and re-enable this warning. 303 # TODO fix this and re-enable this warning.
304 "-Wno-sign-compare", 304 "-Wno-sign-compare",
305 ] 305 ]
306 306
307 import("//build/config/compiler/compiler.gni") 307 import("//build/config/compiler/compiler.gni")
308 import("//build/config/sanitizers/sanitizers.gni") 308 import("//build/config/sanitizers/sanitizers.gni")
309 if (is_component_build && !using_sanitizer) { 309 if (is_component_build || using_sanitizer) {
310 # WARNING! We remove this config so that we don't accidentally 310 # WARNING! We remove this config so that we don't accidentally
311 # pick up the //build/config:rpath_for_built_shared_libraries 311 # pick up the //build/config:rpath_for_built_shared_libraries
312 # sub-config. However, this means that we need to duplicate any 312 # sub-config. However, this means that we need to duplicate any
313 # other flags that executable_config might have. 313 # other flags that executable_config might have.
314 configs -= [ "//build/config:executable_config" ] 314 configs -= [ "//build/config:executable_config" ]
315 if (!use_gold) { 315 if (!use_gold) {
316 ldflags = [ "-Wl,--disable-new-dtags" ] 316 ldflags = [ "-Wl,--disable-new-dtags" ]
317 } 317 }
318 } 318 }
319 319
320 deps = [ 320 # We also do not want to pick up any of the other sanitizer
321 "//build/config/sanitizers:deps", 321 # flags (i.e. we do not want to build w/ the sanitizers at all).
322 ] 322 # This is safe to delete unconditionally, because it is part of the
323 # default configs and empty when not using the sanitizers.
324 configs -= [ "//build/config/sanitizers:default_sanitizer_flags" ]
323 } 325 }
324 } 326 }
325 327
326 component("sandbox_services") { 328 component("sandbox_services") {
327 sources = [ 329 sources = [
328 "services/init_process_reaper.cc", 330 "services/init_process_reaper.cc",
329 "services/init_process_reaper.h", 331 "services/init_process_reaper.h",
330 "services/proc_util.cc", 332 "services/proc_util.cc",
331 "services/proc_util.h", 333 "services/proc_util.h",
332 "services/resource_limits.cc", 334 "services/resource_limits.cc",
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
449 451
450 if (is_android) { 452 if (is_android) {
451 # TODO(GYP_GONE) Delete this after we've converted everything to GN. 453 # TODO(GYP_GONE) Delete this after we've converted everything to GN.
452 group("sandbox_linux_unittests_deps") { 454 group("sandbox_linux_unittests_deps") {
453 testonly = true 455 testonly = true
454 deps = [ 456 deps = [
455 ":sandbox_linux_unittests", 457 ":sandbox_linux_unittests",
456 ] 458 ]
457 } 459 }
458 } 460 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698