Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Issue 2152063002: Harden a security CHECK in Font::individualCharacterRanges (Closed)

Created:
4 years, 5 months ago by pdr.
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Harden a security CHECK in Font::individualCharacterRanges This patch switches to a check (crash) for an assertion failure in Font::individualCharacterRanges which is only known to occur on OSX 10.9.5. A comment has been added to explain this further. This has the side benefit of exposing other cases of this bug on other platforms that may be a more serious issue. BUG=620952 Review-Url: https://codereview.chromium.org/2110703002 Cr-Commit-Position: refs/heads/master@{#402912} (cherry picked from commit e4ff7ba1cfab002517238841505ca9bb7aff6595) Committed: https://chromium.googlesource.com/chromium/src/+/da8f89d0a31c471924f02479b126a7e0bb709205

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M third_party/WebKit/Source/platform/fonts/Font.cpp View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
pdr.
4 years, 5 months ago (2016-07-14 22:45:18 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
da8f89d0a31c471924f02479b126a7e0bb709205.

Powered by Google App Engine
This is Rietveld 408576698