Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2110703002: Harden a security CHECK in Font::individualCharacterRanges (Closed)

Created:
4 years, 5 months ago by pdr.
Modified:
4 years, 5 months ago
Reviewers:
fs
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Harden a security CHECK in Font::individualCharacterRanges This patch switches to a check (crash) for an assertion failure in Font::individualCharacterRanges which is only known to occur on OSX 10.9.5. A comment has been added to explain this further. This has the side benefit of exposing other cases of this bug on other platforms that may be a more serious issue. BUG=620952 Committed: https://crrev.com/e4ff7ba1cfab002517238841505ca9bb7aff6595 Cr-Commit-Position: refs/heads/master@{#402912}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M third_party/WebKit/Source/platform/fonts/Font.cpp View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
pdr.
4 years, 5 months ago (2016-06-28 22:31:55 UTC) #2
fs
lgtm
4 years, 5 months ago (2016-06-29 08:03:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2110703002/1
4 years, 5 months ago (2016-06-29 17:05:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 19:56:04 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-29 19:56:54 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 19:57:23 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e4ff7ba1cfab002517238841505ca9bb7aff6595
Cr-Commit-Position: refs/heads/master@{#402912}

Powered by Google App Engine
This is Rietveld 408576698