Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(389)

Issue 2151893002: Perform BSP polygon splitting and orientation selection in a single step. (Closed)

Created:
2 years, 8 months ago by Tobias Sargeant
Modified:
2 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Perform BSP polygon splitting and orientation selection in a single step. This eliminates redundant testing of vertices for orientation with respect to the splitting polygon. Previously, up to 3 sets of tests were made (once to determine whether the polygon was split, then once during the split, and then finally to determine the orientation of the split polygons. Merging these steps in order to reuse calculated values also eliminates the possibility that different calculations in testing and splitting could be inconsistent. BUG=606984 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/89c62c8f69d76471e866f21ee4f1ae5e0c5bca48 Review-Url: https://codereview.chromium.org/2043283002 Cr-Original-Commit-Position: refs/heads/master@{#399459} Cr-Commit-Position: refs/heads/master@{#403559} (cherry picked from commit 3e9082bfc63be6b304543ee499354fd71ea063ae) Committed: https://chromium.googlesource.com/chromium/src/+/ec22e9bf9c94141511ddd60c80270bfe90dc4526

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+271 lines, -284 lines) Patch
M cc/output/bsp_tree.h View 1 chunk +0 lines, -4 lines 0 comments Download
M cc/output/bsp_tree.cc View 2 chunks +16 lines, -43 lines 0 comments Download
M cc/output/bsp_tree_unittest.cc View 4 chunks +34 lines, -8 lines 0 comments Download
M cc/quads/draw_polygon.h View 1 chunk +4 lines, -7 lines 0 comments Download
M cc/quads/draw_polygon.cc View 3 chunks +140 lines, -181 lines 0 comments Download
M cc/quads/draw_polygon_unittest.cc View 11 chunks +74 lines, -36 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Tobias Sargeant
2 years, 8 months ago (2016-07-14 14:50:28 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ec22e9bf9c94141511ddd60c80270bfe90dc4526.

Powered by Google App Engine
This is Rietveld 408576698