Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2151883004: [Layout API] Use more layoutViewItem() in Document (Closed)

Created:
4 years, 5 months ago by pilgrim_google
Modified:
4 years, 5 months ago
Reviewers:
eae, jsbell
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof, dgrogan
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Layout API] Use more layoutViewItem() in Document follow-on to https://codereview.chromium.org/2126973004 Document::layoutView() is deprecated and being removed soon. The replacement is Document::layoutViewItem(), which routes methods through the new block layout API. (See linked crbug for details.) No new layout API methods were required in this CL. There are no functional changes. BUG=499321 Committed: https://crrev.com/25eb0c4c830433108f6f33ad25dc6f7c24b91ec2 Cr-Commit-Position: refs/heads/master@{#405605}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/core/dom/Document.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
pilgrim_google
4 years, 5 months ago (2016-07-14 19:57:46 UTC) #3
eae
LGTM
4 years, 5 months ago (2016-07-14 21:48:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2151883004/1
4 years, 5 months ago (2016-07-14 21:49:15 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 22:28:43 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-14 22:28:49 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 22:30:46 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/25eb0c4c830433108f6f33ad25dc6f7c24b91ec2
Cr-Commit-Position: refs/heads/master@{#405605}

Powered by Google App Engine
This is Rietveld 408576698