Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 2126973004: [Layout API] Use layoutViewItem() in Document (Closed)

Created:
4 years, 5 months ago by pilgrim_google
Modified:
4 years, 5 months ago
Reviewers:
cbiesinger, eae, jsbell
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-layout_chromium.org, chromium-reviews, dglazkov+blink, dgrogan, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rwlbuis, sof, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Layout API] Use layoutViewItem() in Document Document::layoutView() is deprecated and being removed soon. The replacement is Document::layoutViewItem(), which routes methods through the new block layout API. (See linked crbug for details.) Several new API methods were added which simply proxy to the underlying layout object. As this is a fairly critical class and may show up in automatic blame lists in the future, I should point out that the layout API has absolutely no performance penalty. These proxy objects (LayoutItem and friends) are not ever created at runtime; they disappear completely during compilation/linking. The underlying code produced is identical to what was being produced before this CL. There are no functional changes. BUG=499321 Committed: https://crrev.com/9639f3cbd3fccd1aeee5c320f56cdfdf023ee99f Cr-Commit-Position: refs/heads/master@{#404733}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -21 lines) Patch
M third_party/WebKit/Source/core/dom/Document.cpp View 12 chunks +21 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/core/layout/api/LayoutBlockItem.h View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/api/LayoutItem.h View 2 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
pilgrim_google
4 years, 5 months ago (2016-07-07 20:07:47 UTC) #2
cbiesinger
lgtm
4 years, 5 months ago (2016-07-08 22:13:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2126973004/1
4 years, 5 months ago (2016-07-11 13:41:50 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/253004)
4 years, 5 months ago (2016-07-11 15:41:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2126973004/1
4 years, 5 months ago (2016-07-11 20:06:38 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-11 21:23:39 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-11 21:23:52 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9639f3cbd3fccd1aeee5c320f56cdfdf023ee99f Cr-Commit-Position: refs/heads/master@{#404733}
4 years, 5 months ago (2016-07-11 21:26:22 UTC) #14
eae
4 years, 5 months ago (2016-07-12 16:25:52 UTC) #15
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698