Clear callback pointer after using it in AutofillPaymentInstrument.

Clear callback pointer after using it in AutofillPaymentInstrument.

BUG=628143
Committed: https://crrev.com/c06f5513dc0d40f7dbd2f7c1d52490f8777ed321
Cr-Commit-Position: refs/heads/master@{#405517}

[please use gerrit instead, 2016-07-14 14:43:42]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 14:44:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[please use gerrit instead, 2016-07-14 14:44:56]

rouslan@chromium.org changed reviewers:
+ dfalcantara@chromium.org, mlamouri@chromium.org

[please use gerrit instead, 2016-07-14 14:44:57]

dfalcantara@, ptal.

mlamouri@, fyi.

[please use gerrit instead, 2016-07-14 14:45:16]

Description was changed from

==========
Clear saved callback after using it in AutofillPaymentInstrument.

BUG=628143
==========

to

==========
Clear callback pointer after using it in AutofillPaymentInstrument.

BUG=628143
==========

[commit-bot: I haz the power, 2016-07-14 15:33:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 15:34:00]

Dry run: This issue passed the CQ dry run.

[gone, 2016-07-14 17:19:27]

https://chromiumcodereview.appspot.com/2151883003/diff/1/chrome/android/java/...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java
(right):

https://chromiumcodereview.appspot.com/2151883003/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java:122:
mCallback.onInstrumentDetailsError();
Should this check if mCallback is non null before doing this?

[please use gerrit instead, 2016-07-14 17:31:23]

https://chromiumcodereview.appspot.com/2151883003/diff/1/chrome/android/java/...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java
(right):

https://chromiumcodereview.appspot.com/2151883003/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java:122:
mCallback.onInstrumentDetailsError();
On 2016/07/14 17:19:27, dfalcantara wrote:
> Should this check if mCallback is non null before doing this?

That can't happen. No need for assert either, because there will be a null
pointer crash on the next line, so we can catch this quickly if some new code
breaks this assumption.

[gone, 2016-07-14 17:40:53]

lgtm

[please use gerrit instead, 2016-07-14 17:44:56]

The CQ bit was checked by rouslan@chromium.org

[commit-bot: I haz the power, 2016-07-14 17:45:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 18:17:56]

Description was changed from

==========
Clear callback pointer after using it in AutofillPaymentInstrument.

BUG=628143
==========

to

==========
Clear callback pointer after using it in AutofillPaymentInstrument.

BUG=628143
==========

[commit-bot: I haz the power, 2016-07-14 18:17:57]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-14 18:18:02]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-14 18:21:28]

Description was changed from

==========
Clear callback pointer after using it in AutofillPaymentInstrument.

BUG=628143
==========

to

==========
Clear callback pointer after using it in AutofillPaymentInstrument.

BUG=628143

Committed: https://crrev.com/c06f5513dc0d40f7dbd2f7c1d52490f8777ed321
Cr-Commit-Position: refs/heads/master@{#405517}
==========

[commit-bot: I haz the power, 2016-07-14 18:21:29]

Patchset 1 (id:??) landed as
https://crrev.com/c06f5513dc0d40f7dbd2f7c1d52490f8777ed321
Cr-Commit-Position: refs/heads/master@{#405517}