Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2389)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java

Issue 2151883003: Clear callback pointer after using it in AutofillPaymentInstrument. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNoShippingTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java b/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java
index 682acfee84d655cc4ab2befe179c2182d26ce4e1..aa705adb7d819b84f6e6053ba388ddfb3f41dd1c 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java
@@ -106,7 +106,7 @@ public class AutofillPaymentInstrument
json.endObject();
} catch (IOException e) {
- mCallback.onInstrumentDetailsError();
+ onFullCardError();
return;
}
@@ -120,6 +120,7 @@ public class AutofillPaymentInstrument
@Override
public void onFullCardError() {
mCallback.onInstrumentDetailsError();
gone 2016/07/14 17:19:27 Should this check if mCallback is non null before
please use gerrit instead 2016/07/14 17:31:23 That can't happen. No need for assert either, beca
+ mCallback = null;
}
@Override
« no previous file with comments | « no previous file | chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNoShippingTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698