Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 215183002: Prevent a null crash when window.history is called during detach. (Closed)

Created:
6 years, 9 months ago by Nate Chapin
Modified:
6 years, 9 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews
Visibility:
Public.

Description

Prevent a null crash when window.history is called during detach. In certain rare cases, history.{push,replace}State are called when during plugin detach. In this case, it's possible for the state modification to be requested on a frame that is half-way detached. The Document is still live, but the DocumentLoader is gone. Exit early in this case. BUG=356424 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170219

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/core/frame/History.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
Nate Chapin
The repro involves plugins doing crazy things synchronously on teardown, thus sapping all motivation to ...
6 years, 9 months ago (2014-03-27 18:40:12 UTC) #1
abarth-chromium
plugins -> cry LGTM
6 years, 9 months ago (2014-03-27 21:06:46 UTC) #2
Nate Chapin
The CQ bit was checked by japhet@chromium.org
6 years, 9 months ago (2014-03-27 21:08:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/215183002/1
6 years, 9 months ago (2014-03-27 21:08:27 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 21:19:41 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-27 21:19:41 UTC) #6
Nate Chapin
The CQ bit was checked by japhet@chromium.org
6 years, 9 months ago (2014-03-27 21:20:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/215183002/1
6 years, 9 months ago (2014-03-27 21:20:46 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 22:33:04 UTC) #9
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 9 months ago (2014-03-27 22:33:04 UTC) #10
Nate Chapin
The CQ bit was checked by japhet@chromium.org
6 years, 9 months ago (2014-03-27 23:02:15 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/215183002/1
6 years, 9 months ago (2014-03-27 23:02:18 UTC) #12
commit-bot: I haz the power
6 years, 9 months ago (2014-03-27 23:27:08 UTC) #13
Message was sent while issue was closed.
Change committed as 170219

Powered by Google App Engine
This is Rietveld 408576698