Source/core/frame/History.cpp - Issue 215183002: Prevent a null crash when window.history is called during detach.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/History.cpp

Issue 215183002: Prevent a null crash when window.history is called during detach. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/frame/History.cpp

diff --git a/Source/core/frame/History.cpp b/Source/core/frame/History.cpp

index 3d82ad6adacc6381129c8b9cad137e8842d3c37a..f0c3a0595a4a57dfd2ec920b8eb7826803b778eb 100644

--- a/Source/core/frame/History.cpp

+++ b/Source/core/frame/History.cpp

@@ -125,7 +125,7 @@ KURL History::urlForState(const String& urlString)

void History::stateObjectAdded(PassRefPtr<SerializedScriptValue> data, const String& /* title */, const String& urlString, UpdateBackForwardListPolicy updateBackForwardListPolicy, ExceptionState& exceptionState)

{

- if (!m_frame || !m_frame->page())

+ if (!m_frame || !m_frame->page() || !m_frame->loader().documentLoader())

return;

KURL fullURL = urlForState(urlString);

« no previous file with comments | « no previous file | no next file » | no next file with comments »